Bug #44393
closed
- Project changed from mgr to CephFS
- Subject changed from mgr/volumes: add `mypy` support to pybind/mgr/volumes: add `mypy` support
- Category deleted (
ceph-mgr)
- Status changed from New to Fix Under Review
- Assignee set to Michael Fritch
- Priority changed from Normal to High
- Backport set to nautilus
- Component(FS) mgr/volumes added
- Status changed from Fix Under Review to Pending Backport
- Copied to Backport #44473: nautilus: pybind/mgr/volumes: add `mypy` support added
(venv) smithfarm@wilbur:~/src/ceph/smithfarm/ceph> git branch --contains e20ad96dbfbdc9396e852a40a8d878f0cfb9a584
master
* octopus
No "octopus" backport needed.
a backport for this is more involved that it would appear due to lack of
mypy
support in nautilus and the need for the py3
typing
module.
should we consider closing this issue and only support
mypy
from octopus forward?
- Status changed from Pending Backport to Resolved
Michael Fritch wrote:
a backport for this is more involved that it would appear due to lack of [...] support in nautilus and the need for the py3 [...] module.
should we consider closing this issue and only support [...] from octopus forward?
Agree.
Just to clarify, there is no src/pybind/mgr/tox.ini in nautilus and fef6450834b665b8b05703a8cbb690a04c4ba217 which added mgr/volumes to the mypy checks in that file was not backported, but a substantial part of https://github.com/ceph/ceph/pull/33674 (i.e. commits fixing various bugs found by running the mypy checks on the code in master) was backported to nautilus via this tracker issue.
Also available in: Atom
PDF