Project

General

Profile

Actions
Copy link

Bug #44117

closed

vstart_runner.py: align LocalRemote.run with teuthology's run

Added by Rishabh Dave about 4 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Rishabh Dave
Category:
-
Target version:
Ceph - v15.0.0
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
qa-suite
Labels (FS):
Pull request ID:
33263
Crash signature (v1):
Crash signature (v2):

Description

teuthology's run uses keyword argument but that's not the case for vstart_runner.py. This gets the test passing with vstart_runner.py but it some cases the testing with teuthology goes unsuccessful. Therefore it's better to keep the interfaces aligned so that the test-writer gets the warning without a trip of teuthology testing.

Calls like client_remote.run([<cmdargs>], <more-args>) falls into this categoery. These calls ideally should be client_remote.run(args=[<cmdargs>], <more-KWargs>).

Actions
Copy link

Also available in: Atom PDF