Bug #43746
closed
mgr default value handling is broken
Added by Sage Weil over 4 years ago.
Updated about 4 years ago.
Backport:
nautilus, octopus
Description
most mgr modules have a config_notify() that does
setattr(self,
opt['name'], # type: ignore
self.get_module_option(opt['name']) or opt['default']) # type: ignore
which is applied after the get_module_option in mgr_module.py already sorts out the default values. this breaks any values of 0 or false or none or ''.
- Status changed from In Progress to Fix Under Review
- Pull request ID set to 32755
- Status changed from Fix Under Review to Pending Backport
- Copied to Backport #43820: nautilus: mgr default value handling is broken added
- Backport changed from nautilus to nautilus, octopus
- Copied to Backport #44754: octopus: mgr default value handling is broken added
- Status changed from Pending Backport to Resolved
While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".
Also available in: Atom
PDF