Project

General

Profile

Actions

Bug #43610

open

mgr/dashboard: perform validation on GRAFANA_API_URL

Added by Ernesto Puerta over 4 years ago. Updated over 1 year ago.

Status:
Fix Under Review
Priority:
Normal
Category:
Monitoring
Target version:
-
% Done:

100%

Source:
Q/A
Tags:
low-hanging-fruit
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Currently GRAFANA_API_URL expects "http[s]://<FQDN>:<port>" syntax, but allows also "<FQDN>:<port>".

However that latter expression results in the concatenation of the Dashboard address + Grafana address (e.g.: Grafana Iframe source points to "http://<dash_hostname>:<dash_port>/<grafana_hostname>:<grafana_port>"/d/...").

Unless is for an intentional use-case, the CLI command "ceph dashboard set-grafana-api-url" should perform some check and indicate any errors if this format is entered.

Actions

Also available in: Atom PDF