Project

General

Profile

Actions

Bug #43536

closed

[pubsub] remove deprecated radogw-admin pubsub creation commands

Added by David Piper over 4 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Target version:
-
% Done:

100%

Source:
Community (user)
Tags:
pubsub
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Testing pubsub on v14.2.2 in a containerized deployment ( ceph/daemon:v4.0.3-stable-4.0-nautilus-centos-7 )

Pubsub forces me to specify a RGW user, but allows me to create a topic for an unknown uid:

$ sudo docker exec ceph-mon-newwalesa_0 radosgw-admin user list
[
"zone.user"
]

$ sudo docker exec ceph-mon-newwalesa_0 radosgw-admin pubsub topic create --topic footopic --rgw-zone siteA-pubsub
ERROR: user id was not provided (via --uid)
$ sudo docker exec ceph-mon-newwalesa_0 radosgw-admin pubsub topic create --topic footopic --rgw-zone siteA-pubsub --uid foo

This topic appears for all non-existent users:

$ sudo docker exec ceph-mon-newwalesa_0 radosgw-admin pubsub topics list --rgw-zone siteA-pubsub --uid foo {
"topics": [ {
"topic": {
"user": "",
"name": "footopic"
},
"subs": []
}
]
}
$ sudo docker exec ceph-mon-newwalesa_0 radosgw-admin pubsub topics list --rgw-zone siteA-pubsub --uid bar {
"topics": [ {
"topic": {
"user": "",
"name": "footopic"
},
"subs": []
}
]
}

I can get into a similar state by creating a topic for an existing user, and then deleting the user.


Subtasks 1 (0 open1 closed)

Bug #45794: [pubsub] remove hardcoded "pubsub" user from confWon't Fix

Actions
Actions #1

Updated by Casey Bodley over 4 years ago

  • Assignee set to Yuval Lifshitz
  • Tags set to pubsub
Actions #2

Updated by Yuval Lifshitz over 4 years ago

configuring topics, notifications and subscriptions via radosgw-admin is an "undocumented feature"... (mainly used for internal testing).
unless there is a real usecase for it, it would probably be better to remove it completely.

Actions #3

Updated by David Piper over 4 years ago

Is the suggested method to use the API as per https://docs.ceph.com/docs/nautilus/radosgw/pubsub-module/ or does the "undocumented feature" label apply to pubsub in its entirety?

We've been able to configure pubsub topics etc. using the command line tools, and have been testing pubsub. Is this stable, or is there a risk of the topics / notifications provisioned via the command line not functioning correctly.

Actions #4

Updated by Yuval Lifshitz over 4 years ago

David Piper wrote:

Is the suggested method to use the API as per https://docs.ceph.com/docs/nautilus/radosgw/pubsub-module/ or does the "undocumented feature" label apply to pubsub in its entirety?

The entire feature is fine :-) The official and documented way of creating topics etc. is with the REST API, not the commandline tool

We've been able to configure pubsub topics etc. using the command line tools, and have been testing pubsub. Is this stable, or is there a risk of the topics / notifications provisioned via the command line not functioning correctly.

The commandline tool was not properly tested for pubsub, however, once you have the topics, notifications and subscriptions in place, the notifications will be sent correctly. It was not tested for well for adding, deleting and modifying the topics etc. (as you found out.

As a side note, https://docs.ceph.com/docs/nautilus/radosgw/pubsub-module/ describe the solution for "pull mode" (or "pull + push" mode), where you want the notifications to be stored inside ceph.
If in your usecase you just want to push the notifications to an external system, please consider using: https://docs.ceph.com/docs/nautilus/radosgw/notifications/

Actions #5

Updated by David Piper over 4 years ago

Okay great - thanks for the response.

We do require the "pull" mode with notifications stored on ceph, so pubsub looks like our only option. We'll look into using the REST API.

Thanks!

Actions #6

Updated by Yuval Lifshitz about 4 years ago

  • Subject changed from [pubsub] Possible to create orphaned topics to [pubsub] remove deprecated radogw-admin pubsub creation commands

in addition, the get/list commands should be tested and documented

Actions #7

Updated by Yuval Lifshitz almost 4 years ago

  • Source set to Community (user)
Actions #8

Updated by Yuval Lifshitz almost 4 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 35331
Actions #9

Updated by Casey Bodley almost 4 years ago

  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF