Project

General

Profile

Actions

Bug #43061

closed

ceph fs add_data_pool doesn't set pool metadata properly

Added by Paul Emmerich over 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
octopus,nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
MDSMonitor
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

maybe related to https://tracker.ceph.com/issues/36028

root@ceph-dev-build ~/ceph/build $ ./bin/ceph osd pool create test 1
*** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
2019-11-29T00:16:15.153+0100 7fa7b35ad700 -1 WARNING: all dangerous and experimental features are enabled.
2019-11-29T00:16:15.253+0100 7fa7b35ad700 -1 WARNING: all dangerous and experimental features are enabled.
pool 'test' created
root@ceph-dev-build ~/ceph/build $ ./bin/ceph osd pool application enable test cephfs
*** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
2019-11-29T00:16:30.657+0100 7f084ca39700 -1 WARNING: all dangerous and experimental features are enabled.
2019-11-29T00:16:30.761+0100 7f084ca39700 -1 WARNING: all dangerous and experimental features are enabled.
enabled application 'cephfs' on pool 'test'
root@ceph-dev-build ~/ceph/build $ ./bin/ceph fs add_data_pool a test
*** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
2019-11-29T00:16:54.521+0100 7f1f8f622700 -1 WARNING: all dangerous and experimental features are enabled.
2019-11-29T00:16:54.613+0100 7f1f8f622700 -1 WARNING: all dangerous and experimental features are enabled.
added data pool 3 to fsmap
root@ceph-dev-build ~/ceph/build $ ./bin/ceph osd pool application get test
*** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
2019-11-29T00:17:11.977+0100 7fbcc4c72700 -1 WARNING: all dangerous and experimental features are enabled.
2019-11-29T00:17:12.093+0100 7fbcc4c72700 -1 WARNING: all dangerous and experimental features are enabled.
{
    "cephfs": {}
}


Related issues 2 (0 open2 closed)

Copied to CephFS - Backport #45229: nautilus: ceph fs add_data_pool doesn't set pool metadata properlyResolvedRamana RajaActions
Copied to CephFS - Backport #45230: octopus: ceph fs add_data_pool doesn't set pool metadata properlyResolvedRamana RajaActions
Actions #1

Updated by Patrick Donnelly over 4 years ago

  • Status changed from New to Triaged
  • Assignee set to Ramana Raja
  • Target version set to v15.0.0
  • Source set to Development
  • Backport set to nautilus
  • Component(FS) MDSMonitor added
Actions #2

Updated by Ramana Raja over 4 years ago

  • Status changed from Triaged to In Progress
$ ./bin/ceph osd pool create test 1
$ ./bin/ceph fs add_data_pool a test
$ ./bin/ceph osd pool application get test 
{
    "cephfs": {
        "data": "a" 
    }
}

`add_data_pool` sets the pool's meta data properly if the pool's application metadata isn't already set/enabled.

In the description, the `osd pool application enable test cephfs` sets the pool's application to `cephfs`. The subsequent `fs add_data_pool` command doesn't update the contents of the pool's application metadata. To get around this for now, you can, execute `osd pool application set test cephfs data a`.

Actions #3

Updated by Patrick Donnelly over 4 years ago

Ramana Raja wrote:

[...]
`add_data_pool` sets the pool's meta data properly if the pool's application metadata isn't already set/enabled.

In the description, the `osd pool application enable test cephfs` sets the pool's application to `cephfs`. The subsequent `fs add_data_pool` command doesn't update the contents of the pool's application metadata. To get around this for now, you can, execute `osd pool application set test cephfs data a`.

So if the file system is empty in the "data" field, I would suggest we could overwrite it with the file system name in `add_data_pool`. Makes sense?

Actions #4

Updated by Patrick Donnelly about 4 years ago

Status on this Ramana?

Actions #5

Updated by Patrick Donnelly about 4 years ago

  • Target version changed from v15.0.0 to v16.0.0
  • Backport changed from nautilus to octopus,nautilus
Actions #6

Updated by Ramana Raja about 4 years ago

  • Pull request ID set to 34534
Actions #7

Updated by Greg Farnum about 4 years ago

  • Status changed from In Progress to Pending Backport
Actions #8

Updated by Nathan Cutler almost 4 years ago

  • Copied to Backport #45229: nautilus: ceph fs add_data_pool doesn't set pool metadata properly added
Actions #9

Updated by Nathan Cutler almost 4 years ago

  • Copied to Backport #45230: octopus: ceph fs add_data_pool doesn't set pool metadata properly added
Actions #10

Updated by Nathan Cutler almost 4 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions

Also available in: Atom PDF