Project

General

Profile

Actions
Copy link

Bug #42958

closed

mgr/PyModule.cc: set_config with an empty value doesn't remove the config option

Added by Tim Serong over 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Tim Serong
Category:
ceph-mgr
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
31807
Crash signature (v1):
Crash signature (v2):

Description

PyModuleConfig::set_config() is meant to set a configuration option if a value is provided, and remove the option if no value is passed. The setting part works fine, the removing part, not so much. For example, if you run `ceph orchestrator set backend ''` to unset the orchestrator backend, the mgr/orchestrator_cli/orchestrator config option remains present, and the mgr log says:

2019-11-22T04:18:55.840+0100 7f2807c67700  0 mgr[py] `config set mgrmgr/orchestrator_cli/orchestrator --` failed: (22) Invalid argument
2019-11-22T04:18:55.840+0100 7f2807c67700  0 mgr[py] mon returned -22: unrecognized config target ''

Related issues 1 (0 open — 1 closed)

Copied to mgr - Backport #48768: nautilus: mgr/PyModule.cc: set_config with an empty value doesn't remove the config optionResolvedNathan CutlerActions
Actions
Copy link

Also available in: Atom PDF