Project

General

Profile

Actions

Fix #4192

closed

osd: fix log trimming

Added by Sage Weil about 11 years ago. Updated about 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
OSD
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

We should trim the log even when we're degraded.

Define 'osd pg max log' or similar to control how big we let it get before trimming. Keeping it longer is good because it allows recovery for a temporarily-down replica, but it can't be allowed to grow indefinitely.


Related issues 1 (0 open1 closed)

Related to Ceph - Bug #4116: common/HeartbeatMap.cc: 79: FAILED assert(0 == "hit suicide timeout")ResolvedSage Weil02/13/2013

Actions
Actions #1

Updated by Greg Farnum about 11 years ago

I thought not trimming the log was a deliberate choice for faster catchup. Sounds like we need to define a better policy for when to trim and when not to, but don't just flip/erase a switch, right?

Actions #2

Updated by Sage Weil about 11 years ago

  • Description updated (diff)
Actions #3

Updated by Sage Weil about 11 years ago

  • Translation missing: en.field_story_points set to 5.00
Actions #4

Updated by Sage Weil about 11 years ago

  • Status changed from New to In Progress
Actions #5

Updated by Sage Weil about 11 years ago

  • Target version set to v0.59
Actions #6

Updated by Sage Weil about 11 years ago

  • Assignee set to Sage Weil
Actions #7

Updated by Sage Weil about 11 years ago

  • Status changed from In Progress to Resolved
Actions #8

Updated by Evan Felix about 11 years ago

This code fix seems to have disappeared in version v0.58

Actions #9

Updated by Sage Weil about 11 years ago

It's not in v0.57 either, but is queued for v0.59 (out monday). Pushed wip-log-4192 based on v0.58 that includes the 3 patches that you can use in the meantime!

Actions

Also available in: Atom PDF