Project

General

Profile

Actions
Copy link

Bug #41574

open

mgr/dashboard: use consistent HTML titling hierarchies in forms

Added by Ernesto Puerta over 4 years ago. Updated about 2 years ago.

Status:
In Progress
Priority:
Normal
Assignee:
Carolina Silva
Category:
General
Target version:
-
% Done:

0%

Source:
Tags:
low-hanging-fruit, usability
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Currently forms (and other hierarchical elements) rely on HTML <h[1-6]> tags to define the structure of information/fields/etc. However they also use <legend> elements, or just <div>'s styled with *-header, *-body, *-group, etc.

That leads to inconsistent structure in the DOM, and often also weird appearance in forms and other elements.

Example: pool-form.component form's title is <h3>, then there's a <legend> element "Compression", which appears bigger than the Form header, and another sub-element with title <h3>. This also happens to other forms (RBD, etc).

We should agree whether we want to structure based on HTML headings (properly styled) or HTML5 <section> + classes with a consistent styling (e.g: PF4 does this), and refactor those elements.

XHTML 2 <h> would've been great here too, but unfortunately it seems it's born dead.

Files

titles.png (21.9 KB) titles.png Ernesto Puerta, 08/29/2019 11:30 AM
Actions
Copy link

Also available in: Atom PDF