Subtask #4126
closed
Feature #2770: krbd: define tasks to add osd_client compound class op support
kernel osd client: kill off some dead code
Added by Alex Elder about 11 years ago.
Updated about 11 years ago.
Description
While looking through how to implement multiple ops I have
noticed that there's some dead code in the osd client, or
in some cases code that looks promising but is never actually
used in the kernel (maybe just half implemented). Its presence
unnecessarily complicates the process of changing how things
work, so I want to just clear all that out to simplify things.
To be of most benefit, this should probably be done early.
Here are two examples, but once you start down this path
other things typically emerge that result in removal or
simplification of things:
- osd_req_encode_op() handles encoding some ops that are
never used, including CEPH_OSD_OP_*ETXATTR. Here I'd
remove the code associated with them but handle these
values gracefully (reporting a warning message).
- ceph_osdc_writepages() has only one caller, and four
of the values it provides are constants and can therefore
be eliminated.
- Status changed from New to Fix Under Review
(Oops, I forgot to mark this in progress yesterday.)
The following have been posted for review to resolve this
issue.
[PATCH 0/4] libceph: get rid of some unneeded function parameters
[PATCH 1/4] ceph: kill ceph_osdc_writepages() "nofail" parameter
[PATCH 2/4] ceph: kill ceph_osdc_writepages() "dosync" parameter
[PATCH 3/4] ceph: kill ceph_osdc_writepages() "flags" parameter
[PATCH 4/4] ceph: kill ceph_osdc_new_request() "num_reply"
[PATCH 0/3] libceph: a few miscellaneous cleanups
[PATCH 1/3] libceph: lock outside send_queued()
[PATCH 2/3] libdeph: don't export ceph_osdc_init() or
[PATCH 3/3] libceph: kill ceph_calc_raw_layout()
[PATCH 0/2] libceph: get rid of unused "one shot" event support
[PATCH 1/2] libceph: kill ceph_osdc_create_event() "one_shot"
[PATCH 2/2] libceph: kill ceph_osdc_wait_event()
[PATCH 0/2] libceph: update osd_req_encode_op()
[PATCH 1/2] libceph: report defined but unsupported osd ops
[PATCH 2/2] libceph: remove dead code in osd_req_encode_op()
[PATCH] libceph: simplify data length calculation
- Status changed from Fix Under Review to Resolved
- Translation missing: en.field_remaining_hours set to 0.00
87f979d ceph: kill ceph_osdc_writepages() "nofail" parameter
fbf8685 ceph: kill ceph_osdc_writepages() "dosync" parameter
2480882 ceph: kill ceph_osdc_writepages() "flags" parameter
a3bea47 ceph: kill ceph_osdc_new_request() "num_reply" parameter
f9d2519 libceph: lock outside send_queued()
6078938 libdeph: don't export ceph_osdc_init() or ceph_osdc_stop()
60e56f1 libceph: kill ceph_calc_raw_layout()
3c663bb libceph: kill ceph_osdc_create_event() "one_shot" parameter
2d2f522 libceph: kill ceph_osdc_wait_event()
4c46459 libceph: report defined but unsupported osd ops
a9f36c3 libceph: remove dead code in osd_req_encode_op()
03ae55a libceph: simplify data length calculation
Also available in: Atom
PDF