Project

General

Profile

Bug #40747

Recent rgw-website change causes master FTBFS on OpenSUSE Build Service

Added by Nathan Cutler almost 2 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The OpenSUSE Build Service takes various precautions designed to prevent vectors for malicious code execution from entering the operating system. One of these checks is now failing for the most recent build of Ceph master:

[ 7240s] I: Program returns random data in a function
[ 7240s] E: ceph no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/ceph-15.0.0-2657-ge41b17ad50/src/rgw/rgw_rest_s3.cc:3577
[ 7240s] 
[ 7240s] I: Program returns random data in a function
[ 7240s] E: ceph no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/ceph-15.0.0-2657-ge41b17ad50/src/rgw/rgw_rest_s3.cc:3577

The problematic code, introduced by 4ffc765c4c5debc665ade7769c4647c3a7278fd2, is:

RGWOp *RGWHandler_REST_Bucket_S3::get_obj_op(bool get_data)
{
  // Non-website mode
  int list_type = 1;
  s->info.args.get_int("list-type", &list_type, 1); 

   // Non-website mode    // Non-website mode
  if (get_data) {   
    if (list_type == 1) {
       return new RGWListBucket_ObjStore_S3;    
    } else if(list_type == 2) {
      return new RGWListBucket_ObjStore_S3v2;
    } } else {
    return new RGWStatBucket_ObjStore_S3;    
  }   } 

Related issues

Duplicated by rgw - Bug #42881: nautilus: rgw: "Program returns random data in a function" in src/rgw/rgw_rest_s3.cc Duplicate 11/19/2019
Copied to rgw - Backport #42836: nautilus: Recent rgw-website change causes master FTBFS on OpenSUSE Build Service Resolved

History

#1 Updated by Nathan Cutler almost 2 years ago

  • Subject changed from rgw-website to Recent rgw-website change causes master FTBFS on OpenSUSE Build Service
  • Assignee set to Nathan Cutler

#2 Updated by Jos Collin almost 2 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 28809

#3 Updated by Nathan Cutler almost 2 years ago

  • Assignee changed from Nathan Cutler to Jos Collin

#4 Updated by Nathan Cutler almost 2 years ago

  • Description updated (diff)

#5 Updated by Jos Collin almost 2 years ago

  • Status changed from Fix Under Review to Resolved

#6 Updated by Ernesto Puerta over 1 year ago

  • Backport set to nautilus

#7 Updated by Ernesto Puerta over 1 year ago

  • Status changed from Resolved to Pending Backport

#8 Updated by Ernesto Puerta over 1 year ago

  • Copied to Backport #42836: nautilus: Recent rgw-website change causes master FTBFS on OpenSUSE Build Service added

#9 Updated by Nathan Cutler over 1 year ago

  • Duplicated by Bug #42881: nautilus: rgw: "Program returns random data in a function" in src/rgw/rgw_rest_s3.cc added

#10 Updated by Nathan Cutler over 1 year ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Also available in: Atom PDF