Bug #39579
mgr/dashboard: Fix run-tox script to accept cli arguments again
Status:
Resolved
Priority:
High
Assignee:
Category:
Testing & QA
Target version:
% Done:
0%
Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Tags:
Description
A regression was introduced by this change , causing the script to not accept command line arguments. Therefore command described in the hacking.rst to only run a single tox test ("WITH_PYTHON2=OFF ./run-tox.sh pytest tests/test_rgw_client.py::RgwClientTest::test_ssl_verify") did not work anymore and caused tox to fail .
Traceback (most recent call last): File "/usr/bin/tox", line 11, in <module> load_entry_point('tox==3.7.0', 'console_scripts', 'tox')() File "/usr/lib/python3.7/site-packages/tox/session.py", line 47, in cmdline main(args) File "/usr/lib/python3.7/site-packages/tox/session.py", line 54, in main retcode = build_session(config).runcommand() File "/usr/lib/python3.7/site-packages/tox/session.py", line 467, in runcommand return self.subcommand_test() File "/usr/lib/python3.7/site-packages/tox/session.py", line 590, in subcommand_test self.run_sequential() File "/usr/lib/python3.7/site-packages/tox/session.py", line 609, in run_sequential self.runtestenv(venv) File "/usr/lib/python3.7/site-packages/tox/session.py", line 728, in runtestenv self.hook.tox_runtest(venv=venv, redirect=redirect) File "/usr/lib/python3.7/site-packages/pluggy/hooks.py", line 289, in __call__ return self._hookexec(self, self.get_hookimpls(), kwargs) File "/usr/lib/python3.7/site-packages/pluggy/manager.py", line 68, in _hookexec return self._inner_hookexec(hook, methods, kwargs) File "/usr/lib/python3.7/site-packages/pluggy/manager.py", line 62, in <lambda> firstresult=hook.spec.opts.get("firstresult") if hook.spec else False, File "/usr/lib/python3.7/site-packages/pluggy/callers.py", line 208, in _multicall return outcome.get_result() File "/usr/lib/python3.7/site-packages/pluggy/callers.py", line 80, in get_result raise ex[1].with_traceback(ex[2]) File "/usr/lib/python3.7/site-packages/pluggy/callers.py", line 187, in _multicall res = hook_impl.function(*args) File "/usr/lib/python3.7/site-packages/tox/venv.py", line 597, in tox_runtest venv.test(redirect=redirect) File "/usr/lib/python3.7/site-packages/tox/venv.py", line 468, in test if argv[0].startswith("-"): IndexError: list index out of range
Related issues
History
#1 Updated by Nathan Cutler almost 5 years ago
- Status changed from New to In Progress
- Assignee set to Nathan Cutler
#2 Updated by Nathan Cutler almost 5 years ago
- Status changed from In Progress to Fix Under Review
- Pull request ID set to 27947
#3 Updated by Nathan Cutler almost 5 years ago
Note: backport to nautilus will be handled via #39323
#4 Updated by Nathan Cutler almost 5 years ago
- Related to Bug #39323: tox failures when running "make check" added
#5 Updated by Lenz Grimmer almost 5 years ago
- Tags set to regression
#6 Updated by Lenz Grimmer almost 5 years ago
- Status changed from Fix Under Review to Resolved
#7 Updated by Ernesto Puerta almost 3 years ago
- Tracker changed from Fix to Bug
- Project changed from mgr to Dashboard
- Category changed from 151 to Testing & QA
- Regression set to No
- Severity set to 3 - minor