Project

General

Profile

Actions

Bug #38401

closed

mgr/dashboard: config option detail - replace "Yes/No" by check icon

Added by Tatjana Dehler about 5 years ago. Updated about 3 years ago.

Status:
Rejected
Priority:
Normal
Category:
General
Target version:
-
% Done:

0%

Source:
Development
Tags:
dashboard, configuration
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Replace "Yes/No" text by checkIcon for field "Can be updated at runtime (editable)" on configurations overview page (similar to the table view).

Actions #1

Updated by Volker Theile about 5 years ago

As far as i remember we only display plain text and badges in the details tables. I vote to keep that and not to display icons in such tables. Keep in mind that most of such detail tables are not hard coded like in the Cluster configuration page, thus the consistency will be broken then.

Actions #2

Updated by Tatjana Dehler about 5 years ago

Volker Theile wrote:

As far as i remember we only display plain text and badges in the details tables. I vote to keep that and not to display icons in such tables. Keep in mind that most of such detail tables are not hard coded like in the Cluster configuration page, thus the consistency will be broken then.

Yes, that's true. The reason why I added the issue: the consistency between the table and the item detail view is currently broken for the configurations page from my point of view. It would be possible to fix it here. But this would result in an inconsistency to other table/item detail views. So I guess the question we need to clarify is:

Do we want to live with:
  1. An inconsistency between table and item detail view even on pages where it could be fixed
  2. An inconsistency between table and item detail views on the dashboard in general (between the ones that can and can't be fixed)
Actions #3

Updated by Tatjana Dehler about 5 years ago

  • Status changed from New to Rejected

I reject the issue because of the consistency issues mentioned in https://tracker.ceph.com/issues/38401#note-1 .

Actions #4

Updated by Ernesto Puerta about 3 years ago

  • Project changed from mgr to Dashboard
  • Category changed from 132 to General
Actions

Also available in: Atom PDF