Project

General

Profile

Bug #2592

osd and all clients: watch version parameter is ignored

Added by Josh Durgin over 11 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Watch operations have a version parameter that is supposed act like an assert_version op. This could easily be done in the clients by having ObjectOperation::add_watch add an assert version op as well, but the rbd kernel module was depending on this behavior to detect races with establishing a watch on the header. I'd suggest implementing this as an assert version op, and adding that to the kernel too.

History

#1 Updated by Greg Farnum over 11 years ago

Alternatively, maybe the OSD should just enforce the version with those checks when setting a watch? It looks to me as if that was the intention, but maybe I'm missing something and there's a case where you don't want that.

#2 Updated by Samuel Just over 8 years ago

  • Status changed from New to Resolved

Also available in: Atom PDF