Project

General

Profile

Feature #2556

rbd tool: break image locks

Added by Greg Farnum over 7 years ago. Updated almost 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
Start date:
06/12/2012
Due date:
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Once #1480 is done, expose lock breaking via the rbd tool.

Associated revisions

Revision eeaa92c4 (diff)
Added by Josh Durgin about 7 years ago

rbd: add locking commands

The locker (entity_name_t) will be different each time the rbd
command line tool is run, so 'lock remove' is always breaking a lock.

Fixes: #2556
Signed-off-by: Josh Durgin <>

Revision 8f2a0d91 (diff)
Added by Josh Durgin almost 7 years ago

rbd: add locking commands

The locker (entity_name_t) will be different each time the rbd
command line tool is run, so 'lock remove' is always breaking a lock.

Fixes: #2556
Signed-off-by: Josh Durgin <>

History

#1 Updated by Sage Weil over 7 years ago

  • Subject changed from Expose lock breaking via rbd tool to rbd tool: break image locks
  • translation missing: en.field_position set to 1313

#2 Updated by Sage Weil over 7 years ago

  • translation missing: en.field_story_points set to 2
  • translation missing: en.field_position deleted (1314)
  • translation missing: en.field_position set to 1314

#3 Updated by Sage Weil over 7 years ago

  • Target version deleted (v0.49)
  • translation missing: en.field_position deleted (1315)
  • translation missing: en.field_position set to 2

#4 Updated by Greg Farnum about 7 years ago

  • Status changed from New to In Progress
  • Target version set to v0.49

Team RBD needs more to do! Pulling this forward. :)

#5 Updated by Sage Weil about 7 years ago

Greg Farnum wrote:

Team RBD needs more to do! Pulling this forward. :)

Go team! :)

#6 Updated by Greg Farnum about 7 years ago

  • Status changed from In Progress to Need Review

wip-rbd-locking has this now, but it also merges in wip-clsrbd for an unrelated change, so you might want to wait to review it until stuff is merged together in a cleaner way.

#7 Updated by Sage Weil about 7 years ago

rebase, fixed up ENOENT vs ENOEXEC behavior. one clarification about the purpose/scope of 'rbd lock', but otherwise looks ok to me!

#8 Updated by Greg Farnum about 7 years ago

Your commits look good to me (sorry I missed the cli tests; I need to get into the habit of running those), but I don't see any changes that talk about locking?
Josh said he'd review this tomorrow; waiting for that to merge.

#9 Updated by Sage Weil about 7 years ago

https://github.com/ceph/ceph/commit/3c05629691deb800e3c6e62e81f444a748e8857c#src-rbd-cc-P108

just making sure i understand correctly... 'rbd lock' will always need to be broken manually?

#10 Updated by Greg Farnum about 7 years ago

Argh. I don't seem to be getting my email notifications from you and Josh on Github, and I don't know why.

#11 Updated by Sage Weil about 7 years ago

  • Project changed from Ceph to rbd

#12 Updated by Sage Weil about 7 years ago

  • Target version deleted (v0.49)

#13 Updated by Sage Weil about 7 years ago

  • Target version set to v0.49
  • translation missing: en.field_position deleted (18)
  • translation missing: en.field_position set to 1

#14 Updated by Josh Durgin about 7 years ago

  • Status changed from Need Review to Verified
  • Assignee deleted (Greg Farnum)

The current progress in is wip-rbd-locking. Still needs tests and docs, plus a small cleanup as noted on github.

#15 Updated by Sage Weil about 7 years ago

  • Target version changed from v0.49 to v0.50

#16 Updated by Sage Weil about 7 years ago

  • translation missing: en.field_position deleted (18)
  • translation missing: en.field_position set to 3

#17 Updated by Sage Weil about 7 years ago

  • Target version deleted (v0.50)
  • translation missing: en.field_position deleted (3)
  • translation missing: en.field_position set to 15

#18 Updated by Josh Durgin about 7 years ago

  • translation missing: en.field_position deleted (29)
  • translation missing: en.field_position set to 2

#19 Updated by Sage Weil about 7 years ago

  • Target version set to v0.53a
  • translation missing: en.field_position deleted (12)
  • translation missing: en.field_position set to 10

#20 Updated by Sage Weil about 7 years ago

  • Target version changed from v0.53a to v0.53b
  • translation missing: en.field_position deleted (13)
  • translation missing: en.field_position set to 2

#21 Updated by Josh Durgin about 7 years ago

  • Status changed from Verified to Need Review
  • Assignee set to Josh Durgin

wip-librbd-locking

#22 Updated by Josh Durgin almost 7 years ago

  • Status changed from Need Review to Resolved

Also available in: Atom PDF