Feature #2556: rbd tool: break image locks - rbd - Ceph

Feature #2556

rbd tool: break image locks

Added by Greg Farnum over 11 years ago. Updated about 11 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Josh Durgin

Target version:

v0.53b

% Done:

Source:

Tags:

Backport:

Reviewed:

Affected Versions:

Pull request ID:

Description

Once #1480 is done, expose lock breaking via the rbd tool.

Associated revisions

Revision eeaa92c4 (diff)
Added by Josh Durgin about 11 years ago

rbd: add locking commands

The locker (entity_name_t) will be different each time the rbd
command line tool is run, so 'lock remove' is always breaking a lock.

Fixes: #2556
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>

Revision 8f2a0d91 (diff)
Added by Josh Durgin about 11 years ago

rbd: add locking commands

The locker (entity_name_t) will be different each time the rbd
command line tool is run, so 'lock remove' is always breaking a lock.

Fixes: #2556
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>

History

#1 Updated by Sage Weil over 11 years ago

Subject changed from Expose lock breaking via rbd tool to rbd tool: break image locks
translation missing: en.field_position set to 1313

#2 Updated by Sage Weil over 11 years ago

translation missing: en.field_story_points set to 2
translation missing: en.field_position deleted (~~1314~~)
translation missing: en.field_position set to 1314

#3 Updated by Sage Weil over 11 years ago

Target version deleted (~~v0.49~~)
translation missing: en.field_position deleted (~~1315~~)
translation missing: en.field_position set to 2

#4 Updated by Greg Farnum over 11 years ago

Status changed from New to In Progress
Target version set to v0.49

Team RBD needs more to do! Pulling this forward. :)

#5 Updated by Sage Weil over 11 years ago

Greg Farnum wrote:

Team RBD needs more to do! Pulling this forward. :)

Go team! :)

#6 Updated by Greg Farnum over 11 years ago

Status changed from In Progress to Fix Under Review

wip-rbd-locking has this now, but it also merges in wip-clsrbd for an unrelated change, so you might want to wait to review it until stuff is merged together in a cleaner way.

#7 Updated by Sage Weil over 11 years ago

rebase, fixed up ENOENT vs ENOEXEC behavior. one clarification about the purpose/scope of 'rbd lock', but otherwise looks ok to me!

#8 Updated by Greg Farnum over 11 years ago

Your commits look good to me (sorry I missed the cli tests; I need to get into the habit of running those), but I don't see any changes that talk about locking?
Josh said he'd review this tomorrow; waiting for that to merge.