Actions
Bug #2360
closedosd: inconsistent use of dirty_info = true vs write_info()
Status:
Resolved
Priority:
Urgent
Assignee:
-
Category:
OSD
Target version:
-
% Done:
0%
Source:
Development
Tags:
Backport:
Regression:
Severity:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
The dirty_info flag was added ages ago to avoid stuff done during advance*N + activate_map from rewriting the pg info zillions of times. Now some of the stuff called from that path is also called from other paths which don't check dirty_info (generate_past_intervals(), for one).
I think we want something similar to this, but i'm not sure if it should be pushed up into OSD.cc (any handle_*() is followed by if (dirty_info)...) or whether the osdmap refactoring will push the N advance_map's into PG.cc and it'll be best handled there. Hopefully the latter...
But in any case, that this needs an audit.
Actions