Project

General

Profile

Actions

Feature #23552

open

cache PK11Context in Connection and probably other consumers of CryptoKeyHandler

Added by Kefu Chai about 6 years ago. Updated about 6 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Performance/Resource Usage
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Component(RADOS):
Pull request ID:

Description

please see attached flamegraph, the 0.67% CPU cycle is used by PK11_CreateContextBySymKey(), if we cache the PK11Context returned by this function, we can save the cost. but please note, the PK11Context is not thread safe: we cannot share the same PK11Context instance across multiple threads. So, if we decide to cache it, we will need to move it to the upper level, for example, the messenger's Connection class, that would cover both simple and async messengers. so there will be only a single thread at a give time accessing it.


Files

osd.0.perf.svg.gz (260 KB) osd.0.perf.svg.gz Kefu Chai, 04/04/2018 08:05 AM
Actions

Also available in: Atom PDF