Feature #23003
closed
- Subject changed from Show journal information to Throw a warning/notice when --journal is specified with --bluestore
I'm changing this to a suggestion since ceph-volume /does/ display journal information. ceph noobs like me might benefit from being notified that bluestore OSDs don't have journals.
- Status changed from New to In Progress
I have a work in progress to address this, but it is non-trivial as there isn't support in argparse to express a group of flags that are incompatible with a second group of flags.
It merely has support for just a simple XOR implementation, that is: from a group of flags, only one can be chosen (https://docs.python.org/2/library/argparse.html#mutual-exclusion)
The fix will poke at the argparse object, but it will not support anything that is not passed in (e.g. default flags).
- Status changed from In Progress to Need More Info
David: given that there is no actual support for this in argparse, and I am not fully confident in my implementation, would a warning rather than an error suffice? In the past, for other
tools that give lots of output, it might not be visible enough to just send out warnings.
But a warning that might not be seen (but still be present in the output) is better than stopping on a false positive or not giving anything back at all.
Would you be OK with just a warning in this case?
Alfredo Deza wrote:
Would you be OK with just a warning in this case?
Absolutely -- especially given the fact that the message is being displayed due to my user error.
- Status changed from Need More Info to Fix Under Review
- Assignee set to Alfredo Deza
- Status changed from Fix Under Review to Resolved
merged commit a09b319 into master
Also available in: Atom
PDF