Project

General

Profile

Actions
Copy link

Bug #22297

closed

ceph-volume should handle inline comments in the ceph.conf file

Added by Brad Hubbard over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Alfredo Deza
Target version:
Ceph - v12.2.2
% Done:

0%

Source:
Community (user)
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Having an inline comment in the ceph.conf file read by ceph-volume can result in cascading failures such as follows.

# ceph-volume lvm prepare --bluestore  --data /dev/sdv
Running command: sudo vgcreate --force --yes
ceph-b2f1b9b9-eecc-4c17-8b92-cfa60b31c121 # use uuidgen to create an ID,
use this for all ceph nodes in your cluster /dev/sdv
 stderr: Name contains invalid character, valid set includes:
[a-zA-Z0-9.-_+].
  New volume group name "ceph-b2f1b9b9-eecc-4c17-8b92-cfa60b31c121 # use
uuidgen to create an ID, use this for all ceph nodes in your cluster" is
invalid.
  Run `vgcreate --help' for more information.
-->  RuntimeError: command returned non-zero exit status: 3

Perhaps the use of SafeConfigParser requires a value for inline_comment_prefixes?

Actions
Copy link

Also available in: Atom PDF