Project

General

Profile

Cleanup #2191

reexamine simple_spinlock

Added by Greg Farnum over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

We've got a homebrewed spinlock implementation in src/common/simple_spin.h/cc. It was written so we could use dout in global constructors (which prevent us from properly doing dynamic allocation on a pthread_spinlock), but we should look at at it again. Can we:
1) eliminate the use of dout in global constructors? (and thus the need for this)
2) do a better job with the busy loop, since nobody's quite sure about the timing on it?
3) hack up something so we only use this to do the initial dout pthread spinlock initialization?

History

#1 Updated by Sage Weil over 7 years ago

my log branch drops this for the dout logging. the last user is the buffer.h debugging (enabled manually via a macro). given how often that's used, i don't think it's worth even looking at it anytime soon..

#2 Updated by Sage Weil over 7 years ago

  • Status changed from New to Resolved

Also available in: Atom PDF