Ceph » rgw

test case in https://github.com/ceph/ceph/pull/18271

This rgw_bucket_complete_op() cls call for the multipart complete also includes the 4 multipart parts in remove_objs, so they can be removed from the index at the same time.

We also call log_index_operation() to add bilog entries for those removes - but we don't increment the header.ver for each, which means that each of those operations writes to the same omap key, overwriting the previous entries.

Some osd log snippets to illustrate:

rgw_bucket_complete_op(): request: op=0 name=MULTIPART instance= ver=7:4 tag=e6094249-4ff0-4912-9ea3-08d0f1b200e3.4109.38
log_index_operation name=MULTIPART key=<80>0_00000000012.12.1 op=0 state=1 tag=e6094249-4ff0-4912-9ea3-08d0f1b200e3.4109.38
rgw_bucket_complete_op(): remove_objs.size()=4

rgw_bucket_complete_op(): removing entries, read_index_entry name=_multipart_MULTIPART.2~vtcUTJNUDdfY4O6pLxOUTXjJjoNlI_Y.1 instance=
rgw_bucket_complete_op(): entry.name=_multipart_MULTIPART.2~vtcUTJNUDdfY4O6pLxOUTXjJjoNlI_Y.1 entry.instance= entry.meta.category=1
log_index_operation name=_multipart_MULTIPART.2~vtcUTJNUDdfY4O6pLxOUTXjJjoNlI_Y.1 key=<80>0_00000000012.12.1 op=1 state=1 tag=e6094249-4ff0-4912-9ea3-08d0f1b200e3.4109.38

rgw_bucket_complete_op(): removing entries, read_index_entry name=_multipart_MULTIPART.2~vtcUTJNUDdfY4O6pLxOUTXjJjoNlI_Y.2 instance=
rgw_bucket_complete_op(): entry.name=_multipart_MULTIPART.2~vtcUTJNUDdfY4O6pLxOUTXjJjoNlI_Y.2 entry.instance= entry.meta.category=1
log_index_operation name=_multipart_MULTIPART.2~vtcUTJNUDdfY4O6pLxOUTXjJjoNlI_Y.2 key=<80>0_00000000012.12.1 op=1 state=1 tag=e6094249-4ff0-4912-9ea3-08d0f1b200e3.4109.38

rgw_bucket_complete_op(): removing entries, read_index_entry name=_multipart_MULTIPART.2~vtcUTJNUDdfY4O6pLxOUTXjJjoNlI_Y.3 instance=
rgw_bucket_complete_op(): entry.name=_multipart_MULTIPART.2~vtcUTJNUDdfY4O6pLxOUTXjJjoNlI_Y.3 entry.instance= entry.meta.category=1
log_index_operation name=_multipart_MULTIPART.2~vtcUTJNUDdfY4O6pLxOUTXjJjoNlI_Y.3 key=<80>0_00000000012.12.1 op=1 state=1 tag=e6094249-4ff0-4912-9ea3-08d0f1b200e3.4109.38

rgw_bucket_complete_op(): removing entries, read_index_entry name=_multipart_MULTIPART.2~vtcUTJNUDdfY4O6pLxOUTXjJjoNlI_Y.4 instance=
rgw_bucket_complete_op(): entry.name=_multipart_MULTIPART.2~vtcUTJNUDdfY4O6pLxOUTXjJjoNlI_Y.4 entry.instance= entry.meta.category=1
log_index_operation name=_multipart_MULTIPART.2~vtcUTJNUDdfY4O6pLxOUTXjJjoNlI_Y.4 key=<80>0_00000000012.12.1 op=1 state=1 tag=e6094249-4ff0-4912-9ea3-08d0f1b200e3.4109.38

Casey Bodley wrote:

Updated https://github.com/ceph/ceph/pull/18271 with a proposed fix.

merged