Project

General

Profile

Bug #21738

audit for asserts on shutdown

Added by Greg Farnum almost 2 years ago.

Status:
New
Priority:
High
Assignee:
-
Category:
-
Target version:
-
Start date:
10/09/2017
Due date:
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

In various places we assert conditions are true on shutdown. We would really prefer not to do that for users when it's just internal bookkeeping. See #21737 for one example.

I tried to do a general audit for this by going through destructors, but the best regex I could come up with was:

git grep "~[a-zA-Z]*()[^}]*{[^}]*" -- src/

That returned 783 results. Many of them are actually empty, but all my attempts to exclude those failed, for my regex-fu was not strong enough. (The plan I had was to find a regex that only returned non-empty implementations, then stick a "-A 20" or similar on it, and then search the results for "assert", which ought to have a high enough real hit ratio to be useful.)

Also available in: Atom PDF