Bug #21598
closed
Users can do "config-key set" while mgr runs, but it doesn't see settings
Added by John Spray over 6 years ago.
Updated almost 3 years ago.
Description
This is kind of confusing for users and for module developers.
Originally the config-key stuff was meant to just be a backend, and the user interface was meant to be for the plugins to just expose their own CLIs for setting options safely (including validation etc). We've sort of diverged from that now -- we will soon (hopefully) be moving to a central KV store for all config keys, so for the moment we should either just document this or find some intermediate solution (like maybe adding a mgr command that sets config options in a way that does update the cached copies in the mgr).
Workaround is something like
ceph config-key set mgr/my_module/my_setting value
ceph mgr restart
Different Workaround:
https://github.com/ceph/ceph/blob/ea5c668fea05e3139684f4c19f4b8a3098ab5855/src/pybind/mgr/cephadm/module.py#L1174-L1190
Related issues
1 (1 open — 0 closed)
- Subject changed from People can do "config-key set" while mgr runs, but it doesn't see settings to Users can do "config-key set" while mgr runs, but it doesn't see settings
- Status changed from New to Fix Under Review
- Assignee set to Rubab Syed
- Status changed from Fix Under Review to 12
Lenz: yeah, I had been thinking that with centralised config, we would insist that KV store users would only take values via module commands, not via external "config-key set" stuff. Then when we looked at the key/cert setting for dashboard, we realised that the "-i" file input in the CLI was pretty important, and that wasn't usable with mgr commands.
So I think that probably the best thing to do is try to make "-i" work for mgr module commands, and then make sure that nobody is doing direct "config-key set" any more? Alternatively, we could add a mgr (non-module) command for setting KV store options, that would make it visible to the module and then go set it on the mon as well.
- Assignee deleted (
Rubab Syed)
- Related to Bug #36288: ceph manager not picking up config settings added
- Status changed from 12 to New
- Description updated (diff)
- Description updated (diff)
- Status changed from New to Resolved
- Pull request ID set to 39504
Also available in: Atom
PDF