Cleanup #2150
closed
repair the Simple/Messenger interface
Added by Greg Farnum about 12 years ago.
Updated about 5 years ago.
Description
I made a start on this with my interface work, but there are still
1) a lot of public functions that ought to be private or protected.
2) Functions needing documentation.
3) Subclasses that need to be reordered, have more implementation pushed down into the C file, etc.
Basically, the messenger is an important part of our system. Its header should be legible to outside contributors so they can do things like implement their own on a different network fabric; so newcomers can understand the interface in a reasonable amount of time, etc.
- Target version changed from v0.45 to v0.46
- Translation missing: en.field_position set to 20
- Assignee set to Greg Farnum
- Status changed from New to Resolved
- Status changed from Resolved to In Progress
I haven't done it, but I had enough time to glance over it and see at least a couple things that need fixing before this is marked as resolved.
- Status changed from In Progress to Resolved
- Status changed from Resolved to In Progress
- Status changed from In Progress to 4
- Status changed from 4 to 7
Looks good to me, provided it makes it through the regression suite without problems!
- Target version deleted (
v0.46)
- Translation missing: en.field_position deleted (
65)
- Translation missing: en.field_position set to 8
- Target version set to v0.47
- Translation missing: en.field_position deleted (
8)
- Translation missing: en.field_position set to 8
- Target version changed from v0.47 to v0.48
- Status changed from 7 to 4
I scheduled another test run but I don't anticipate any problems — this should be reviewed for merge!
- Status changed from 4 to Resolved
- Project changed from Ceph to Messengers
- Category deleted (
msgr)
- Target version deleted (
v0.48)
Also available in: Atom
PDF