Project

General

Profile

Cleanup #2150

repair the Simple/Messenger interface

Added by Greg Farnum almost 12 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

I made a start on this with my interface work, but there are still
1) a lot of public functions that ought to be private or protected.
2) Functions needing documentation.
3) Subclasses that need to be reordered, have more implementation pushed down into the C file, etc.

Basically, the messenger is an important part of our system. Its header should be legible to outside contributors so they can do things like implement their own on a different network fabric; so newcomers can understand the interface in a reasonable amount of time, etc.

History

#1 Updated by Sage Weil almost 12 years ago

  • Target version changed from v0.45 to v0.46

#2 Updated by Sage Weil almost 12 years ago

  • translation missing: en.field_position set to 20

#3 Updated by Sage Weil almost 12 years ago

  • Assignee set to Greg Farnum

#4 Updated by Sage Weil almost 12 years ago

  • Status changed from New to Resolved

#5 Updated by Greg Farnum almost 12 years ago

  • Status changed from Resolved to In Progress

I haven't done it, but I had enough time to glance over it and see at least a couple things that need fixing before this is marked as resolved.

#6 Updated by Sage Weil almost 12 years ago

  • Status changed from In Progress to Resolved

#7 Updated by Greg Farnum almost 12 years ago

  • Status changed from Resolved to In Progress

Not really done! ;)

#8 Updated by Greg Farnum almost 12 years ago

  • Status changed from In Progress to 4

wip-msgr-interface

#9 Updated by Sage Weil almost 12 years ago

  • Status changed from 4 to 7

Looks good to me, provided it makes it through the regression suite without problems!

#10 Updated by Sage Weil almost 12 years ago

  • Target version deleted (v0.46)
  • translation missing: en.field_position deleted (65)
  • translation missing: en.field_position set to 8

#11 Updated by Sage Weil almost 12 years ago

  • Target version set to v0.47
  • translation missing: en.field_position deleted (8)
  • translation missing: en.field_position set to 8

#12 Updated by Sage Weil almost 12 years ago

  • Target version changed from v0.47 to v0.48

#13 Updated by Greg Farnum over 11 years ago

  • Status changed from 7 to 4

I scheduled another test run but I don't anticipate any problems — this should be reviewed for merge!

#14 Updated by Sage Weil over 11 years ago

  • Status changed from 4 to Resolved

#15 Updated by Greg Farnum almost 5 years ago

  • Project changed from Ceph to Messengers
  • Category deleted (msgr)
  • Target version deleted (v0.48)

Also available in: Atom PDF