Cleanup #2078
closed
ceph tool: only output response data to stdout
Added by Josh Durgin about 12 years ago.
Updated almost 11 years ago.
Description
By default, "ceph osd getmap" or any other command that fetches binary data outputs it to stdout. However, other info is also sent to stdout, so e.g. piping from the ceph tool to the osdmaptool doesn't work.
This also affects things like ceph pg dump --format=json. You can't pipe it to a pretty printer without ignoring the first useless line 'dumped all in format json'.
i think we need to phase out all of the first-line nonsense.
- Target version set to v0.60
- Status changed from New to 7
- Assignee set to Dan Mick
wip-cephtool-stderr is gitbuilding. I've tested the commands manually; I wonder if it's worth adding unit tests, or if this should just get encompassed in the exhaustive unit tests planned for
the CLI rework.
- Target version deleted (
v0.60)
- Target version set to v0.62a
This will have bigger implications, as teuthology already has workarounds for the existing
broken behavior; need to figure out how much of an issue it'll be for users
- Target version deleted (
v0.62a)
- Translation missing: en.field_story_points set to 5.00
- Project changed from Ceph to 16
- Project changed from 16 to Ceph
- Status changed from 7 to Resolved
A crazy amount of iteration to get to this, but the CLI rewrite has resolved this issue, mostly
by outputting a blank line to stdout in cases where it matters.
Also available in: Atom
PDF