Project

General

Profile

Actions

Cleanup #2078

closed

ceph tool: only output response data to stdout

Added by Josh Durgin about 12 years ago. Updated almost 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

By default, "ceph osd getmap" or any other command that fetches binary data outputs it to stdout. However, other info is also sent to stdout, so e.g. piping from the ceph tool to the osdmaptool doesn't work.

Actions #1

Updated by Josh Durgin over 11 years ago

This also affects things like ceph pg dump --format=json. You can't pipe it to a pretty printer without ignoring the first useless line 'dumped all in format json'.

Actions #2

Updated by Sage Weil over 11 years ago

i think we need to phase out all of the first-line nonsense.

Actions #3

Updated by Sage Weil about 11 years ago

  • Target version set to v0.60
Actions #4

Updated by Dan Mick about 11 years ago

  • Status changed from New to 7
  • Assignee set to Dan Mick
Actions #5

Updated by Dan Mick about 11 years ago

wip-cephtool-stderr is gitbuilding. I've tested the commands manually; I wonder if it's worth adding unit tests, or if this should just get encompassed in the exhaustive unit tests planned for
the CLI rework.

Actions #6

Updated by Ian Colle about 11 years ago

  • Target version deleted (v0.60)
Actions #7

Updated by Ian Colle about 11 years ago

  • Target version set to v0.62a
Actions #8

Updated by Dan Mick about 11 years ago

This will have bigger implications, as teuthology already has workarounds for the existing
broken behavior; need to figure out how much of an issue it'll be for users

Actions #9

Updated by Dan Mick about 11 years ago

  • Target version deleted (v0.62a)
  • Translation missing: en.field_story_points set to 5.00
Actions #10

Updated by Anonymous almost 11 years ago

  • Project changed from Ceph to 16
Actions #11

Updated by Ian Colle almost 11 years ago

  • Project changed from 16 to Ceph
Actions #12

Updated by Dan Mick almost 11 years ago

  • Status changed from 7 to Resolved

A crazy amount of iteration to get to this, but the CLI rewrite has resolved this issue, mostly
by outputting a blank line to stdout in cases where it matters.

Actions

Also available in: Atom PDF