Bug #19883
closed
Remove redundant includes
Added by Brad Hubbard almost 7 years ago.
Updated over 6 years ago.
Description
Ceph source files contain many redundant #includes. Removing these should, in theory, improve compilation times and reduce dependencies.
- Status changed from New to In Progress
Brad,
How did you get these redundancies?
Just running GCC on Linux?
Having a lot of fallout under FreeBSD/Clang
Hi Willem,
Which PRs/commits specifically are you having issues with?
I don't have access to FreeBSD to test with.
Willem Jan Withagen wrote:
Willem Jan Withagen wrote:
Brad,
How did you get these redundancies?
Just running GCC on Linux?
Having a lot of fallout under FreeBSD/Clang
Fix the missing includes in
https://github.com/ceph/ceph/pull/15337
https://github.com/ceph/ceph/pull/15685
core/common: Fix ENODATA for FreeBSD with compat.h
- When ENODATA used, compat.h needs to be include before any
of the includes that could possibly define ENODATA by itself.
Since otherwise xattr-tests will fail to detect that attributes
are (not) there.
- Status changed from In Progress to Closed
Also available in: Atom
PDF