Actions
Bug #18877
closedmds/StrayManager: avoid reusing deleted inode in StrayManager::_purge_stray_logged
Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:
0%
Source:
Community (dev)
Tags:
Backport:
jewel, kraken
Regression:
No
Severity:
2 - major
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
MDS
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
This issue was found by testing another PR (https://github.com/ceph/ceph/pull/12792), which makes MDS directly uses TCMALLOC, not boost::pool. When the version of TCMALLOC is 4.2.6 or above, removing directory will cause MDS crash.
assert((o->lru_list == & lru_pintail) || (o->lru_list ==&lru_top) || (o->lru_list == &lru_b))
The root cause is that in StrayManager::_purge_stray_logged, inode will delete itself firstly, then it tries to drop dentry via this deleted inode. I think it should be the new version of TCMALLOC to expose this issue more easily and obviously.
The fix here is to reorder the dropping sequence. Tests have passed with following test cases:
1. boost::pool with TCMALLOC 4.2.6
2. only TCMALLOC 4.2.6
3. boost::pool with TCMALLOC 4.1.2
4. only TCMALLOC 4.1.2
Actions