Project

General

Profile

Actions

Bug #18491

open

setup_rpm should notify about build status as early as possible

Added by Dan Mick over 7 years ago. Updated over 2 years ago.

Status:
Fix Under Review
Priority:
Normal
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

An attempt was made to fix this in https://github.com/ceph/ceph-build/pull/614, but that broke the rpm build because the operations on ceph.spec.in, namely

sed -e 's/@//g' < ceph.spec.in > $DIR/ceph.spec
, moved across a cd, and operate on relative paths.

Several things ought to happen:

1) ceph.spec.in should be irrelevant to the build; although it's in the dist tarball, ceph.spec should serve for all purposes, as far as I can tell.

2) scripts that cd should refer to files with absolute paths to avoid this sort of brittleness.

Actions

Also available in: Atom PDF