Bug #18393
tests: objecter_requests workunit fails on wip branches
0%
Description
objecter_requests workunit takes an argument "test" specifying a download URL, e.g:
objecter_requests: test: "http://git.ceph.com/?p=ceph.git;a=blob_plain;f=src/test/admin_socket/objecter_requests;hb={branch}"
Since ceph-ci.git has been split off from ceph.git, that download will fail for wip branches since those are found only in ceph-ci.git.
This can be seen in the wild, e.g., here: http://qa-proxy.ceph.com/teuthology/smithfarm-2017-01-02_15:48:30-rados-wip-hammer-backports-distro-basic-smithi/683163/teuthology.log (pertinent log excerpt follows)
2017-01-02T15:58:06.733 INFO:teuthology.orchestra.run.smithi068:Running: 'sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 30 ceph --admin-daemon /var/run/ceph/ceph-osd.5.asok dump_blocked_ops' 2017-01-02T15:58:06.741 DEBUG:tasks.admin_socket:Testing objecter_requests with config {'test': 'http://git.ceph.com/?p=ceph.git;a=blob_plain;f=src/test/admin_socket/objecter_requests;hb={branch}', 'branch': 'wip-hammer-backports'} 2017-01-02T15:58:06.744 INFO:teuthology.orchestra.run.smithi056:Running: "wget -q -O /home/ubuntu/cephtest/admin_socket_client.0/objecter_requests -- 'http://git.ceph.com/?p=ceph.git;a=blob_plain;f=src/test/admin_socket/objecter_requests;hb=wip-hammer-backports' && chmod u=rx -- /home/ubuntu/cephtest/admin_socket_client.0/objecter_requests" ... CommandFailedError: Command failed on smithi056 with status 8: "wget -q -O /home/ubuntu/cephtest/admin_socket_client.0/objecter_requests -- 'http://git.ceph.com/?p=ceph.git;a=blob_plain;f=src/test/admin_socket/objecter_requests;hb=wip-hammer-backports' && chmod u=rx -- /home/ubuntu/cephtest/admin_socket_client.0/objecter_requests"
Following the ceph.git/ceph-ci.git split, this URL is unreliable:
test: "http://git.ceph.com/?p=ceph.git;a=blob_plain;f=src/test/admin_socket/objecter_requests;hb={branch}"
Some branches are only in ceph.git, others only in ceph-ci.git. In this case, the branch is in ceph-ci.git, but "repo" evaluates to ceph.git.
Hence Sage's fix at https://github.com/ceph/ceph/pull/12508
Related issues
History
#1 Updated by Nathan Cutler almost 7 years ago
- Description updated (diff)
- Backport set to hammer,jewel,kraken
#2 Updated by Nathan Cutler almost 7 years ago
- Description updated (diff)
#3 Updated by Nathan Cutler almost 7 years ago
- Description updated (diff)
#4 Updated by Nathan Cutler almost 7 years ago
- Status changed from In Progress to Fix Under Review
master PR: https://github.com/ceph/ceph/pull/12748
#5 Updated by Nathan Cutler almost 7 years ago
- Copied to Backport #18399: hammer: tests: objecter_requests workunit fails on wip branches added
#6 Updated by Nathan Cutler almost 7 years ago
- Description updated (diff)
#7 Updated by Nathan Cutler almost 7 years ago
Loic pointed out that repo is hardcoded to ceph.git in hammer, but not in jewel and beyond. I'm currently testing a hammer-only fix at #18399.
#8 Updated by Nathan Cutler almost 7 years ago
PR to backport: https://github.com/ceph/ceph/pull/12508
#9 Updated by Nathan Cutler almost 7 years ago
- Status changed from Fix Under Review to Pending Backport
#10 Updated by Nathan Cutler almost 7 years ago
- Backport changed from hammer,jewel,kraken to hammer,jewel
#11 Updated by Nathan Cutler almost 7 years ago
- Description updated (diff)
#12 Updated by Nathan Cutler almost 7 years ago
- Copied to Backport #18402: jewel: tests: objecter_requests workunit fails on wip branches added
#13 Updated by Nathan Cutler almost 7 years ago
- Status changed from Pending Backport to Resolved