Project

General

Profile

Bug #18393

Updated by Nathan Cutler over 2 years ago

objecter_requests workunit takes an argument "test" specifying a download URL, e.g:

<pre>
objecter_requests:
test: "http://git.ceph.com/?p=ceph.git;a=blob_plain;f=src/test/admin_socket/objecter_requests;hb={branch}"
</pre>

Since ceph-ci.git has been split off from ceph.git, that download will fail for wip branches since those are found only in ceph-ci.git.

This can be seen in the wild, e.g., here: http://qa-proxy.ceph.com/teuthology/smithfarm-2017-01-02_15:48:30-rados-wip-hammer-backports-distro-basic-smithi/683163/teuthology.log (pertinent log excerpt follows)

<pre>
2017-01-02T15:58:06.733 INFO:teuthology.orchestra.run.smithi068:Running: 'sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 30 ceph --admin-daemon /var/run/ceph/ceph-osd.5.asok dump_blocked_ops'
2017-01-02T15:58:06.741 DEBUG:tasks.admin_socket:Testing objecter_requests with config {'test': 'http://git.ceph.com/?p=ceph.git;a=blob_plain;f=src/test/admin_socket/objecter_requests;hb={branch}', 'branch': 'wip-hammer-backports'}
2017-01-02T15:58:06.744 INFO:teuthology.orchestra.run.smithi056:Running: "wget -q -O /home/ubuntu/cephtest/admin_socket_client.0/objecter_requests -- 'http://git.ceph.com/?p=ceph.git;a=blob_plain;f=src/test/admin_socket/objecter_requests;hb=wip-hammer-backports' && chmod u=rx -- /home/ubuntu/cephtest/admin_socket_client.0/objecter_requests"
...
CommandFailedError: Command failed on smithi056 with status 8: "wget -q -O /home/ubuntu/cephtest/admin_socket_client.0/objecter_requests -- 'http://git.ceph.com/?p=ceph.git;a=blob_plain;f=src/test/admin_socket/objecter_requests;hb=wip-hammer-backports' && chmod u=rx -- /home/ubuntu/cephtest/admin_socket_client.0/objecter_requests"
</pre>

Following the ceph.git/ceph-ci.git split, this URL is unreliable:

<pre>
test: "http://git.ceph.com/?p=ceph.git;a=blob_plain;f=src/test/admin_socket/objecter_requests;hb={branch}" "http://git.ceph.com/?p={repo};a=blob_plain;f=src/test/admin_socket/objecter_requests;hb={branch}"
</pre>

Some branches are *only* in ceph.git, others *only* in ceph-ci.git. In this case, the branch is in ceph-ci.git, but "repo" evaluates to ceph.git.

Hence Sage's fix at https://github.com/ceph/ceph/pull/12508 I guess it will be rare for someone's wip branch to include changes to src/test/admin_socket/objecter_requests so we can just download from the appropriate branch of ceph/ceph.git. If someone needed to download the test from their wip branch, they could override the URL when running the test.

Back