Feature #16468: kclient: Exclude ceph.* xattr namespace in listxattr - CephFS - Ceph

Actions

Copy link

Feature #16468

closed

kclient: Exclude ceph.* xattr namespace in listxattr

Added by John Spray almost 8 years ago. Updated over 4 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Jeff Layton

Category:

Correctness/Safety

Target version:

% Done:

Source:

Tags:

Backport:

Reviewed:

Affected Versions:

Component(FS):

Common/Protocol, kceph

Labels (FS):

Pull request ID:

Description

See this thread: http://www.spinics.net/lists/ceph-devel/msg30948.html

Some userspaces tools (notably rsync) try to copy files' xattrs when copying the files. This causes a problem when rsync tries to copy the ceph vxattrs to a non-ceph filesystem.

We can avoid this issue if we continue to make vxattrs available for get/set, but don't include them in the listing.

Related issues 1 (1 open — 0 closed)

Actions

Copy link

Updated by Greg Farnum almost 8 years ago

Component(FS) kceph added

Actions

Copy link

Updated by Greg Farnum almost 8 years ago

Related to Feature #16467: ceph-fuse: Exclude ceph.* xattr namespace in listxattr added

Actions

Copy link

Updated by Greg Farnum almost 8 years ago

Category changed from 53 to Correctness/Safety
Component(FS) Common/Protocol added

Actions

Copy link

Updated by Venky Shankar almost 8 years ago

I gave a shot at fixing this today (kclient only) as per the email thread.

listxattr() does not return internal xattrs. Also, introduced 'ceph.all' virtual xattr that returns a list of ceph's internal xattrs -- just the names (keys) for now. Will send out the patch to -devel soon.

Actions

Copy link

Updated by Patrick Donnelly over 4 years ago

Assignee set to Xiubo Li
Start date deleted (~~06/24/2016~~)
Source deleted (~~other~~)

Not sure if we fixed this recently. There was some discussion a month or so ago about removing the ceph.* xattrs but I don't recall where it went.

Actions

Copy link

Updated by Xiubo Li over 4 years ago

The ceph.* xattr has been removed, so this has been fixed:

commit e09580b343aa117fd07c1bb7f7dfc5bc630a2953
Author: Jeff Layton <jlayton@kernel.org>
Date: Wed Jul 24 12:46:20 2019 -0400

ceph: don't list vxattrs in listxattr()

Most filesystems that provide virtual xattrs (e.g. CIFS) don't display
them via listxattr(). Ceph does, and that causes some of the tests in
xfstests to fail.

Have cephfs stop listing vxattrs in listxattr. Userspace can always
query them directly when the name is known.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
Acked-by: David Disseldorp <ddiss@suse.de>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>