Feature #15789
closed
Give requested scrubs a higher priority
Added by Samuel Just almost 8 years ago.
Updated almost 7 years ago.
Description
It seems like requested scrubs will wait behind scheduled scrubs, that's not great. Since requested scrubs are already inserted into sched_scrub_pg with an immediate deadline they will be the next to start. Since we can't currently interrupt a scrub which is already in progress there is nothing more to do there. Later in the process we schedule actions with the same priority as regular scrubs. Increasing the priority should be helpful.
Samuel Just wrote:
It seems like requested scrubs will wait behind scheduled scrubs, that's not great.
Samuel, do you mean requested replica scrub map? I find that the priority of requested replica scrub map op is PRIO_DEFAULT(127), it is higher than default scrub priority(5). So the requested scrub map will be processed first. But what do you mean? would you explain more? thank you. ;)
Wanlong Gao wrote:
Samuel Just wrote:
It seems like requested scrubs will wait behind scheduled scrubs, that's not great.
Samuel, do you mean requested replica scrub map? I find that the priority of requested replica scrub map op is PRIO_DEFAULT(127), it is higher than default scrub priority(5). So the requested scrub map will be processed first. But what do you mean? would you explain more? thank you. ;)
Ah, sorry, I understand the requested scrubs means "must_scrub".
- Tracker changed from Bug to Feature
- Status changed from New to In Progress
- Assignee set to David Zafman
- Subject changed from make requested scrubs jump the queue to Give requested scrubs a higher priority
- Description updated (diff)
- Status changed from In Progress to Pending Backport
- Backport set to kraken, jewel
- Copied to Backport #19685: kraken: Give requested scrubs a higher priority added
- Copied to Backport #19686: jewel: Give requested scrubs a higher priority added
- Status changed from Pending Backport to Resolved
Also available in: Atom
PDF