Ceph » devops

It looks like collect_sys_info() is called by OSDs, MONs, and MDSs.

jewel PR: https://github.com/ceph/ceph/pull/7823

+ adding branto to the CC

Why does the OSD have a lsb_release_parse function at all? That seems odd.

We really want to get rid of the lsb-release package dependency.

@Ken, @Boris - the lsb_release executable is run in many places:

qa/qa_scripts/RbdLib.pm:        my $os_distro = get_command_output ( "lsb_release -d" );
qa/qa_scripts/S3Lib.pm:        my $os_distro = get_command_output ( "lsb_release -d" );
qa/workunits/rgw/s3_utilities.pm:        my $os_distro = get_command_output ( "lsb_release -d" );
qa/workunits/ceph-disk/ceph-disk-test.py:        if c.sh("lsb_release -si").strip() == 'CentOS':
qa/workunits/ceph-disk/ceph-disk-test.py:        if c.sh("lsb_release -si").strip() != 'CentOS':
qa/workunits/ceph-helpers-root.sh:    case $(lsb_release -si) in
qa/workunits/ceph-helpers-root.sh:            echo "$(lsb_release -si) is unknown, $@ will have to be installed manually." 
src/ceph-disk/Makefile.am:        if lsb_release -si | grep --quiet 'Ubuntu\|Debian\|Devuan' ; then \
src/ceph-detect-init/Makefile.am:        if lsb_release -si | grep --quiet 'Ubuntu\|Debian\|Devuan' ; then \
src/common/util.cc:static bool lsb_release_set(char *buf, const char *prefix,
src/common/util.cc:static void lsb_release_parse(map<string, string> *m, CephContext *cct)
src/common/util.cc:  FILE *fp = popen("lsb_release -idrc", "r");
src/common/util.cc:    lderr(cct) << "lsb_release_parse - failed to call lsb_release binary with error: " << cpp_strerror(ret) << dendl;
src/common/util.cc:    if (lsb_release_set(buf, "Distributor ID:", m, "distro"))
src/common/util.cc:    if (lsb_release_set(buf, "Description:", m, "distro_description"))
src/common/util.cc:    if (lsb_release_set(buf, "Release:", m, "distro_version"))
src/common/util.cc:    if (lsb_release_set(buf, "Codename:", m, "distro_codename"))
src/common/util.cc:    lderr(cct) << "lsb_release_parse - pclose failed: " << cpp_strerror(ret) << dendl;
src/common/util.cc:  lsb_release_parse(m, cct);
src/osd/OSD.h:  bool _lsb_release_set(char *buf, const char *str, map<string,string> *pm, const char *key);
src/osd/OSD.h:  void _lsb_release_parse (map<string,string> *pm);
src/pybind/rados/Makefile.am:        if lsb_release -si | grep --quiet 'Ubuntu\|Debian\|Devuan' ; then \
src/pybind/rbd/Makefile.am:        if lsb_release -si | grep --quiet 'Ubuntu\|Debian\|Devuan' ; then \
src/script/dep-report.sh:PLATFORM=`lsb_release -is`
src/test/docker-test-helper.sh:   $ lsb_release -d
src/test/docker-test-helper.sh:   bash-4.2$ lsb_release -d
make-debs.sh:codename=$(lsb_release -sc)
make-debs.sh:releasedir=$base/$(lsb_release -si)/WORKDIR
install-deps.sh:case $(lsb_release -si) in
install-deps.sh:        case $(lsb_release -sc) in
install-deps.sh:                backports="-t $(lsb_release -sc)-backports" 
install-deps.sh:        case $(lsb_release -si) in
install-deps.sh:                MAJOR_VERSION=$(lsb_release -rs | cut -f1 -d.)
install-deps.sh:                if test $(lsb_release -si) = RedHatEnterpriseServer ; then
install-deps.sh:                if test $(lsb_release -si) = CentOS -a $MAJOR_VERSION = 7 ; then
install-deps.sh:        echo "$(lsb_release -si) is unknown, dependencies will have to be installed manually."