Project

General

Profile

Actions

Feature #14348

closed

systemd: support multiple clusters

Added by Artemy Kapitula over 8 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

systemd unit files has a hardcoded "ceph" cluster name.

It makes new releases completely unusable on modern Linux systems who are systemd-based (Fedora, CentOS, RedHat).

The suggested solution is to create a wrapper to parse a one-word daemon identifier and pass it to daemons after splitting to cluster/id parts:

ceph-custom-daemon osd clustername.1 => ceph-osd --cluster clustername --id 1
ceph-custom-daemon mon clustername.monid => ceph-mon --cluster clustername --id monid


Files

ceph-9.2.0-osd-prestart.diff (790 Bytes) ceph-9.2.0-osd-prestart.diff /usr/libexec/ceph/ceph-osd-prestart.sh fix Artemy Kapitula, 01/12/2016 09:10 PM
ceph-9.2.0-systemd.diff (6.19 KB) ceph-9.2.0-systemd.diff main patch part Artemy Kapitula, 01/12/2016 09:10 PM
Actions #1

Updated by Samuel Just over 8 years ago

  • Assignee set to Loïc Dachary
Actions #2

Updated by Loïc Dachary over 8 years ago

Would you be so kind as to create a pull request with these proposed changes ?

Actions #3

Updated by Artemy Kapitula about 8 years ago

Loic Dachary wrote:

Would you be so kind as to create a pull request with these proposed changes ?

https://github.com/ceph/ceph/pull/7449

Actions #4

Updated by Tim Serong almost 8 years ago

The "ceph" cluster name isn't hardcoded in the systemd unit files. "Environment=CLUSTER=ceph" is just a default, which can be overridden by setting CLUSTER=whatever in /etc/sysconfig/ceph. Does that not provide enough flexibility for using alternate cluster names? What am I missing here?

Actions #5

Updated by Artemy Kapitula almost 8 years ago

Tim Serong wrote:

The "ceph" cluster name isn't hardcoded in the systemd unit files. "Environment=CLUSTER=ceph" is just a default, which can be overridden by setting CLUSTER=whatever in /etc/sysconfig/ceph. Does that not provide enough flexibility for using alternate cluster names? What am I missing here?

For the most users it's enough, but not for a heavy usage cases.
The first, that's could be OK if you get only the one cluster. If you get many, it's not an option.
The second, configuration files is hard to automate. With @-style it's easy to configure node form command line.

Actions #6

Updated by Loïc Dachary over 7 years ago

  • Assignee deleted (Loïc Dachary)
Actions #7

Updated by Samuel Just over 7 years ago

  • Tracker changed from Bug to Feature
  • Subject changed from systemd unit files broken for all non-default cluster name to systemd: support multiple clusters
  • Priority changed from High to Normal

Sounds like it works fine with non-default names, but doesn't work if you have multiple clusters.

Actions #8

Updated by Sebastian Wagner about 3 years ago

  • Status changed from New to Resolved

fixed by cephadm

Actions

Also available in: Atom PDF