Actions
Bug #13525
closedmon: should not set isvalid = true when cephx_verify_authorizer return false
Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:
0%
Source:
other
Tags:
Backport:
infernalis,hammer
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
if (authorizer_data.length()) {
int ret = cephx_verify_authorizer(g_ceph_context, &keyring, iter,
auth_ticket_info, authorizer_reply);
if (ret >= 0) { //bad!
session_key = auth_ticket_info.session_key;
isvalid = true;
} else {
dout(0) << "ms_verify_authorizer bad authorizer from mon " << con->get_peer_addr() << dendl;
}
}
should use bool instead of int
master PR: https://github.com/ceph/ceph/pull/6306
Actions