Bug #13291
closed
ceph-disk: --zap-disk does not zap the journal device
Added by Loïc Dachary over 8 years ago.
Updated over 8 years ago.
Description
When running ceph-disk prepare --zap-disk /dev/vdb /dev/vdc, only the data device /dev/vdb is zapped. It is counter intuitive and the journal device should also be zapped if present.
I have a fix for this, just checking for the correct pull request
- Tracker changed from Fix to Bug
- Subject changed from ceph-disk: --zap-disk should also zap the journal device to ceph-disk: --zap-disk does not zap the journal device
- Status changed from 12 to Won't Fix
- Regression set to No
[01.10 13:26] <loicd> ceph-disk prepare --zap-disk /dev/vdb /dev/vdc should zap /dev/vdb /dev/vdc but ceph-disk prepare --zap-disk /dev/vdb /dev/vdc1 should only zap /dev/vdb
[01.10 13:27] <loicd> hum
[01.10 13:27] <loicd> maybe people rely on the fact that --zap-disk only zaps the data partition
[01.10 13:27] <oms101> I suspect they do
[01.10 13:27] <loicd> it's confusing but if you change that behavior, scripts will start zapping unexpected things...
[01.10 13:28] <loicd> oh well, that's a won't fix then I guess
[01.10 13:28] <oms101> we do have zap as an explicit zap command which will zap anything
[01.10 13:28] <loicd> yeah
Also available in: Atom
PDF