Project

General

Profile

Actions
Copy link

Bug #12812

closed

Something fails to collect rocksdb sources for dist

Added by Pete Zaitcev over 8 years ago. Updated over 8 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
v9.0.2
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Originally, this started because the current RPM spec cannot be used to build 0.94 (either in-tree ceph.spec.in or the one used to build the latest Fedora RPMs 0.94). In current tree, 9.0.2, "make dist" does not collect the src/rocksdb into the tarball. If this tarball is used to build with --with-librocksdb-static=check, then the build fails once it attempts to build rocksdb.

An easy fix here is to tell everyone stop using rocksdb and update the in-tree spec to drop that flag.

A more proper fix would be to tinker with autoconf so that "make dist" collects necessary source. Surprisingly, just including src/Makefile-rocksdb does not cut it. All the sources get added to ac_librocksdb_la_SOURCES as expected, but they somehow still miss from the tarball.

Actions
Copy link

Also available in: Atom PDF