Project

General

Profile

Actions

Backport #12591

closed

rgw: create a tool for orphaned objects cleanup

Added by Nathan Cutler over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
Release:
hammer
Pull request ID:
Crash signature (v1):
Crash signature (v2):


Related issues 1 (0 open1 closed)

Copied from rgw - Feature #9604: rgw: create a tool for orphaned objects cleanupResolved09/26/2014

Actions
Actions #1

Updated by Ken Dreyer over 8 years ago

For what it's worth, the upstream master PR (https://github.com/ceph/ceph/pull/5109) cherry-picks cleanly onto v0.94.2 at least. Although I did have to leave out the final commit, "rgw: api adjustment following a rebase".

Actions #2

Updated by Loïc Dachary over 8 years ago

  • Description updated (diff)
  • Status changed from New to In Progress
  • Assignee set to Loïc Dachary
Actions #3

Updated by Loïc Dachary over 8 years ago

@Ken : I'd be interested to know why you had to loose the final commit. When I don't include it this is the error I get:

 CXX test/system/rados_list_parallel.o
In file included from rgw/rgw_json_enc.cc:5:0:
rgw/rgw_rados.h: In member function ‘librados::Rados* RGWRados::get_rados()’:

    error: rgw/rgw_rados.h:1275:41: cannot convert ‘librados::Rados**’ to ‘librados::Rados*’ in return 

librados::Rados *get_rados() { return rados; }
^

Actions #4

Updated by Loïc Dachary over 8 years ago

I think I get it now: this backport depends on https://github.com/ceph/ceph/pull/5612. If applied after it, the "rgw: api adjustment following a rebase" commit needs to be discarded.

Actions #5

Updated by Ken Dreyer over 8 years ago

If applied after it, the "rgw: api adjustment following a rebase" commit needs to be discarded.

s/after/before/

?

Actions #6

Updated by Loïc Dachary over 8 years ago

@Ken: what worked without discarding commits nor resolving conflicts is applying all commits on top of https://github.com/ceph/ceph/pull/5612 (that what is in https://github.com/ceph/ceph/pull/5717)

Actions #7

Updated by Loïc Dachary over 8 years ago

  • Status changed from In Progress to Resolved
Actions #8

Updated by Loïc Dachary over 8 years ago

  • Target version set to v0.94.4
Actions

Also available in: Atom PDF