Project

General

Profile

Actions
Copy link

Bug #11587

closed

inconsistency with rbd-replay utilities and --with-debug option

Added by Ken Dreyer almost 9 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

In v0.94.1, make install installs /usr/bin/rbd-replay and /usr/bin/rbd-replay-many even when the user does not specify the --with-debug option to ./configure.

There are a couple inconsistencies here:
  1. In contrast to the other two utilities, the installation of /usr/bin/rbd-replay-prep is dependent on --with-debug.
  2. The rbd-replay, rbd-replay-prep, rbd-replay-many utilities all ship in the "ceph-test" RPM, which is roughly analogous to the "--with-debug" configure option (from what I understand). So I think we should make them all correspond to --with-debug, or else move them out of the ceph-test RPM.
  3. The make install task unconditionally installs the rbd-replay(8), rbd-replay-prep(8), and rbd-replay-many(8) man pages, regardless of whether the rest of the build system installs the utilities themselves.

For the third item, I don't know if we have the capability to conditionally install man pages at this point, so that's not as important as the other two.

Actions
Copy link
 #1

Updated by Samuel Just almost 9 years ago

  • Project changed from Ceph to rbd
Actions
Copy link
 #2

Updated by Josh Durgin almost 9 years ago

Should we move these utilities to ceph-common? They're generally useful rather than just for testing.

Actions
Copy link
 #3

Updated by Jason Dillaman almost 9 years ago

  • Status changed from New to Need More Info
Actions
Copy link
 #4

Updated by Ken Dreyer almost 9 years ago

moving them to ceph-common sounds like a good option to me. And then make /usr/bin/rbd-replay-prep no longer depend on the --with-debug configure option?

Actions
Copy link
 #5

Updated by Jason Dillaman almost 9 years ago

Ken Dreyer wrote:

And then make /usr/bin/rbd-replay-prep no longer depend on the --with-debug configure option?

It actually doesn't depend on the --with-debug option, only on the availability babeltrace-devel ("if WITH_BABELTRACE" section in rbd_prep/Makefile.am)

Actions
Copy link
 #6

Updated by Jason Dillaman over 8 years ago

  • Status changed from Need More Info to Resolved

rbd-replay* utilities are being moved to the ceph-common package under #12994

Actions
Copy link

Also available in: Atom PDF