Project

General

Profile

Actions

Bug #10439

closed

'ceph tell' should fail if daemon is not found

Added by Mykola Golub over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Category:
ceph cli
Target version:
-
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Right now if a daemon specified to 'ceph tell' command does not match 'osd.{number}' format and is not a mon daemon, the command is still sent to one of the mons.

Example:

% ceph tell osd.0 health
no valid command found; 10 closest matches:
...
Error EINVAL: invalid command
(it fails because osd daemon does not support 'health' command, expected)
% ceph tell osd.999 health 
Error ENOENT: problem getting command descriptions from osd.999
(it fails because osd daemon 999 does not exist, expected)
% ceph tell osd.foo health
HEALTH_OK
(a mon daemon returns health, unexpected)
% ceph tell gibberish health
HEALTH_OK
(a mon daemon returns health, unexpected)

A more correct behavior looks like to return a error in the last two cases.

See some discussin at https://github.com/ceph/ceph/pull/3272

Actions

Also available in: Atom PDF