Actions
Bug #9372
closedinjectarg boolean option is discarded
% Done:
100%
Source:
other
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
ceph tell mon.* injectargs --perf
fails because --perf is consumed by the general purpose argument parsing. A simple workaround is to add -- so the general purpose agrument parsing ignores what is after injectargs.
ceph tell mon.* injectargs -- --perf
Here is the session log:
loic@fold:~/software/ceph/ceph/src$ ceph tell mon.* injectargs -- --perf *** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH *** injectargs:perf = 'true' loic@fold:~/software/ceph/ceph/src$ ceph tell mon.* injectargs -- --no-perf *** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH *** injectargs:perf = 'false' loic@fold:~/software/ceph/ceph/src$ ceph tell mon.* injectargs --no-perf *** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH *** Invalid command: saw 0 of injected_args(<string>) [<string>...], expected at least 1 injectargs <injected_args> [<injected_args>...] : inject config arguments into monitor Error EINVAL: invalid command loic@fold:~/software/ceph/ceph/src$ ceph tell mon.* injectargs '--no-perf --no-perf' *** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH *** injectargs:perf = 'false'
Updated by Loïc Dachary over 9 years ago
I have no pull request for this ;-) But I can try and make one if that's what you're suggesting.
Updated by Loïc Dachary over 9 years ago
- Status changed from 12 to Fix Under Review
- % Done changed from 0 to 80
Updated by Loïc Dachary over 9 years ago
expect_false: 46: ceph injectargs mon.a '--mon_pg_warn_min_objects 10F'
*** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
Traceback (most recent call last):
File "./ceph", line 880, in
sys.exit(main())
File "./ceph", line 823, in main
sigdict, inbuf, verbose)
File "./ceph", line 423, in new_style_command
interactive_input = raw_input(prompt)
Error: EOF EOF when reading a line
expect_false: 46: return 0
test_mon_injectargs_SI: 198: ceph daemon mon.a config set mon_pg_warn_min_objects 1000
Updated by Loïc Dachary over 9 years ago
- Status changed from Fix Under Review to Resolved
- % Done changed from 80 to 100
Updated by Loïc Dachary over 9 years ago
There is a warkaround (using --), not sure it deserves backporting.
Actions