Project

General

Profile

Actions

Bug #8476

closed

bloom_filter operators do not handle insert_count_

Added by Sahid Orentino Ferdjaoui almost 10 years ago. Updated almost 10 years ago.

Status:
Resolved
Priority:
Low
Assignee:
-
Category:
common
Target version:
-
% Done:

100%

Source:
Development
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

According to the source code it seems that 'insert_count_' is not taken into account when manipulating objects using operators like (intersect, union, diff...)

bf1 &= bf2
bf1 |= bf2
bf1 ^= bf2

https://github.com/ceph/ceph/blob/master/src/common/bloom_filter.hpp#L359

Actions #1

Updated by Greg Farnum almost 10 years ago

I don't understand, what's the bug here? I don't think we actually use those operators to begin with, and operations like that can't really produce a sensible insert_count anyway.

Actions #2

Updated by Loïc Dachary almost 10 years ago

  • Description updated (diff)
Actions #4

Updated by Sahid Orentino Ferdjaoui almost 10 years ago

Indeed, it is kind of difficult to compute the insert_count_ since the operations are doing by manipulate the bit_table_ directly.
I have preferred to report the issue as a bug since it looks to corrupt some methods like 'fpp' and 'is_full', then let the community decide to solve the problem or not.

Actions #5

Updated by Sahid Orentino Ferdjaoui almost 10 years ago

According to the discuss on IRC, I'm going to fix the bug by removing the methods (intersect, union and diff)

PS: Sorry I didn't assign myself on the bug it looks I don"t have enough privilege or just... I don't know how do that ;-)

Actions #6

Updated by Loïc Dachary almost 10 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF