Project

General

Profile

Feature #760

librbd: Include headers in the development package

Added by Wido den Hollander over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
librbd
Target version:
-
Start date:
02/03/2011
Due date:
% Done:

70%

Spent time:
Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Right now librbd.h and librbd.hpp are not added to librbd1-dev

Attached is a patch which includes them.

0001-librbd-Install-the-headers-in-the-development-packag.patch View (1.18 KB) Wido den Hollander, 02/03/2011 05:07 AM

0002-librbd-Use-the-correct-namespace-for-string-and-buff.patch View (1.59 KB) Wido den Hollander, 02/03/2011 05:52 AM

History

#1 Updated by Wido den Hollander over 8 years ago

Not worth opening a new issue, see the second patch.

Use the right namespace for string and bufferlist.

#2 Updated by Sage Weil over 8 years ago

  • Assignee set to Yehuda Sadeh

#3 Updated by Yehuda Sadeh over 8 years ago

Applying the first patch. Shouldn't the namespace in the second one be ceph and not librados?

#4 Updated by Wido den Hollander over 8 years ago

It's declared in rados/buffer.h, so it should be librados?

Btw, you just added AIO write with a bufferlist without a namespace.

#5 Updated by Yehuda Sadeh over 8 years ago

  • Status changed from New to Resolved

Actually rados/buffer.h is just a symlink to include/buffer.h and is actually under the ceph namespace and shared between the server and client code. I modified the librbd.hpp to use the ceph namespace.

Also available in: Atom PDF