Feature #760

librbd: Include headers in the development package

Added by Wido den Hollander over 2 years ago. Updated over 2 years ago.

Status:ResolvedStart date:02/03/2011
Priority:NormalDue date:
Assignee:Yehuda Sadeh% Done:

70%

Category:librbdSpent time:2.00 hours
Target version:-
Source: Reviewed:
Tags: User Impact:
Story points-
Velocity based estimate-

Description

Right now librbd.h and librbd.hpp are not added to librbd1-dev

Attached is a patch which includes them.

0001-librbd-Install-the-headers-in-the-development-packag.patch Magnifier (1.18 KB) Wido den Hollander, 02/03/2011 05:07 am

0002-librbd-Use-the-correct-namespace-for-string-and-buff.patch Magnifier (1.59 KB) Wido den Hollander, 02/03/2011 05:52 am

History

#1 Updated by Wido den Hollander over 2 years ago

Not worth opening a new issue, see the second patch.

Use the right namespace for string and bufferlist.

#2 Updated by Sage Weil over 2 years ago

  • Assignee set to Yehuda Sadeh

#3 Updated by Yehuda Sadeh over 2 years ago

Applying the first patch. Shouldn't the namespace in the second one be ceph and not librados?

#4 Updated by Wido den Hollander over 2 years ago

It's declared in rados/buffer.h, so it should be librados?

Btw, you just added AIO write with a bufferlist without a namespace.

#5 Updated by Yehuda Sadeh over 2 years ago

  • Status changed from New to Resolved

Actually rados/buffer.h is just a symlink to include/buffer.h and is actually under the ceph namespace and shared between the server and client code. I modified the librbd.hpp to use the ceph namespace.

Also available in: Atom PDF