Actions
Bug #64179
closedclient: check for caps issued before incrementing cap ref
Status:
Rejected
Priority:
High
Assignee:
Category:
Correctness/Safety
Target version:
% Done:
0%
Source:
Development
Tags:
Backport:
quincy,reef
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Client
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
So this came to light when debugging cap leak issue in asyc I/O, while discussing this with xiubo today, we came to know that we do not actually check for the issued caps to the inode before incrementing the respective ref count for that inode in Client::get_cap_ref. The client lock does only make sure no multiple clients operate over the same inode, which leaves to MDS lock, does it guarantee the caps? I don't know. What i think is we should check for the caps issued before incrementing the ref count in `Client::get_cap_ref`
Actions