Project

General

Profile

Actions
Copy link

Bug #6152

closed

New S3 auth code fails when using response-* query string params to override response headers

Added by Sylvain Munaut over 10 years ago. Updated about 10 years ago.

Status:
Resolved
Priority:
High
Assignee:
Yehuda Sadeh
Target version:
-
% Done:

0%

Source:
Community (user)
Tags:
Backport:
dumpling
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Previously there was a list of subresources to ignore when generating a signature. This has changed to a list of subresource to sign but the response-* were not included as they should have been.

Attached is a tested fix.

Files

0001-rgw-Fix-S3-auth-when-using-response-query-string-par.patch (876 Bytes) 0001-rgw-Fix-S3-auth-when-using-response-query-string-par.patch Fix (tested) Sylvain Munaut, 08/29/2013 07:20 AM
Actions
Copy link
 #1

Updated by Ian Colle over 10 years ago

  • Assignee set to Yehuda Sadeh
  • Priority changed from Normal to High
  • Target version deleted (v0.67 - Dumpling)
Actions
Copy link
 #2

Updated by Yehuda Sadeh over 10 years ago

  • Backport set to dumpling
Actions
Copy link
 #3

Updated by Yehuda Sadeh over 10 years ago

  • Status changed from New to Pending Backport
Actions
Copy link
 #4

Updated by Yehuda Sadeh over 10 years ago

  • Status changed from Pending Backport to Resolved

Was already merged into dumpling (commit:9b953aa4100eca5de2319b3c17c54bc2f6b03064).

Actions
Copy link
 #5

Updated by Sylvain Munaut over 10 years ago

That commit has nothing to do with this issue ... this commit is from Februrary and related to duplicate content type headers ...

This issue is related to S3 signature computations ...

Actions
Copy link
 #6

Updated by Benjamin Gilbert over 10 years ago

This is still broken on 0.67.4. Please consider backporting the fix (7a7361d7) to Dumpling.

Actions
Copy link
 #7

Updated by Yehuda Sadeh over 10 years ago

I sent a pull request a few days ago, so this should be in the next dumpling release.

Actions
Copy link
 #8

Updated by Yehuda Sadeh over 10 years ago

  • Status changed from Resolved to Pending Backport
Actions
Copy link
 #9

Updated by Yehuda Sadeh over 10 years ago

  • Assignee changed from Yehuda Sadeh to Josh Durgin

This is still waiting for merge (sent a pull request a week ago).

Actions
Copy link
 #10

Updated by Josh Durgin about 10 years ago

  • Status changed from Pending Backport to Resolved
  • Assignee changed from Josh Durgin to Yehuda Sadeh

backported in commit:4e47a003bb3adcee690067d4037c248a93023c20 a while ago

Actions
Copy link

Also available in: Atom PDF