Feature #59714: mgr/volumes: Support to reject CephFS clones if cloner threads are not available - CephFS - Ceph

Actions

Copy link

Feature #59714

open

mgr/volumes: Support to reject CephFS clones if cloner threads are not available

Added by Neeraj Pratap Singh 12 months ago. Updated about 2 months ago.

Status:

Pending Backport

Priority:

Normal

Assignee:

Neeraj Pratap Singh

Category:

Administration/Usability

Target version:

Ceph - v19.0.0

% Done:

Source:

Tags:

backport_processed

Backport:

reef,quincy,squid

Reviewed:

Affected Versions:

Component(FS):

mgr/volumes

Labels (FS):

Pull request ID:

52670

Description

1. CephFS clone creation have a limit of 4 parallel clones at a time and rest
of the clone create requests are queued. This makes CephFS cloning very slow when there is large amount of clones being created.

2. CephCSI/Kubernetes storage does have a mechanism to delete in-progress clones and deletion of corresponding kubernetes object pvc may lead to stale resource.

Due to the above reasons, there are a lot of customer cases with stale cephfs clones.
For detailed discussion: https://bugzilla.redhat.com/show_bug.cgi?id=2196829

Related issues 4 (2 open — 2 closed)

Actions

Copy link

Updated by Neeraj Pratap Singh 12 months ago

Assignee set to Neeraj Pratap Singh

Actions

Copy link

Updated by Venky Shankar 12 months ago

Category set to Administration/Usability
Target version set to v19.0.0
Backport set to reef,quincy

Actions

Copy link

Updated by Neeraj Pratap Singh 9 months ago

I am thinking to move ahead with this approach: Allow the cloning only when (pending_clones + in-progress_clones) <= max_concurrent_clones, otherwise return the error EAGAIN.@vshankar, @Kotresh Hiremath Ravishankar?

Actions

Copy link

Updated by Kotresh Hiremath Ravishankar 9 months ago

Neeraj Pratap Singh wrote:

I am thinking to move ahead with this approach: Allow the cloning only when (pending_clones + in-progress_clones) <= max_concurrent_clones, otherwise return the error EAGAIN.@vshankar, @Kotresh Hiremath Ravishankar?

The approach looks correct. I think the condition should be (pending_clones + in-progress-clones) < max_concurrent-clones.

Actions

Copy link

Updated by Neeraj Pratap Singh 9 months ago

Kotresh Hiremath Ravishankar wrote:

Neeraj Pratap Singh wrote:

I am thinking to move ahead with this approach: Allow the cloning only when (pending_clones + in-progress_clones) <= max_concurrent_clones, otherwise return the error EAGAIN.@vshankar, @Kotresh Hiremath Ravishankar?

The approach looks correct. I think the condition should be (pending_clones + in-progress-clones) < max_concurrent-clones.

Right, it should only be less than. thanks!

Actions

Copy link

Updated by Neeraj Pratap Singh 9 months ago

Status changed from New to Fix Under Review
Pull request ID set to 52670

Actions

Copy link

Updated by Neeraj Pratap Singh 8 months ago

@Venky Shankar @Kotresh Hiremath Ravishankar Since, I was on sick leave yesterday. I saw the discussion made on the PR today. Seeing the final comment: https://github.com/ceph/ceph/pull/52670#issuecomment-1685809411 , we are moving ahead with the current way of having a config option but now by default this feature will be enabled will be the change expected.Am I right?

Actions

Copy link

Updated by Venky Shankar 8 months ago

Neeraj Pratap Singh wrote:

@Venky Shankar @Kotresh Hiremath Ravishankar Since, I was on sick leave yesterday. I saw the discussion made on the PR today. Seeing the final comment: https://github.com/ceph/ceph/pull/52670#issuecomment-1685809411 , we are moving ahead with the current way of having a config option but now by default this feature will be enabled will be the change expected.Am I right?

Right.

Actions

Copy link