Actions
Bug #58008
closedmds/PurgeQueue: don't consider filer_max_purge_ops when _calculate_ops
Status:
Resolved
Priority:
Normal
Assignee:
Category:
Correctness/Safety
Target version:
% Done:
0%
Source:
Tags:
backport_processed
Backport:
pacific,quincy
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
MDS
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
_calculate_ops relying on a config which can be modified on the fly will cause a bug. e.g.
- A file has 20 objects and filer_max_purge_ops config was 10.
- calling PurgeQueue::_execute_item and _calculate_ops returns 10, so ops_in_flight add 10.
- adjust filer_max_purge_ops to 20 on the fly
- calling PurgeQueue::_execute_item_complete and _calculate_ops returns 20, so ops_in_flight dec 20.
- since ops_in_flight is uint64, this cause an overflow which makes ops_in_flight far more greater than max_purge_ops and can't go back to a reasonable value.
filer_max_purge_ops will still work when _do_purge_range, so it's ok to ignore it here.
Actions