Project

General

Profile

Actions

Bug #55158

closed

mon/OSDMonitor: properly set last_force_op_resend in stretch mode

Added by Ilya Dryomov about 2 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
Correctness/Safety
Target version:
-
% Done:

100%

Source:
Tags:
Backport:
pacific,quincy
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Setting last_force_op_resend but not last_force_op_resend_prenautilus and last_force_op_resend_preluminous doesn't make sense. The reverse, such as

last_force_op_resend = 0
last_force_op_resend_prenautilus = 0
last_force_op_resend_preluminous = 20

or

last_force_op_resend = 0
last_force_op_resend_prenautilus = 40
last_force_op_resend_preluminous = 40

is valid in PG split/merge cases (and is the reason prenautilus and preluminous fields actually exist and aren't just encoding artifacts), but, if last_force_op_resend is set, both prenautilus and preluminous fields should really be set to the same value. Otherwise it basically amounts to "nautilus+ clients need to resend in-flight ops on stretch mode transitions but pre-nautilus clients don't" which is bogus as it leaves pre-nautilus clients exposed to the nastiness that necessitated employing the force resend hammer in the first place in https://github.com/ceph/ceph/commit/97fbd19ccd02046cb643239ac3c6fcb8404b4445.


Related issues 3 (1 open2 closed)

Related to RADOS - Tasks #55159: stretch mode isn't covered in teuthologyNew

Actions
Copied to RADOS - Backport #55280: quincy: mon/OSDMonitor: properly set last_force_op_resend in stretch modeResolvedIlya DryomovActions
Copied to RADOS - Backport #55281: pacific: mon/OSDMonitor: properly set last_force_op_resend in stretch modeResolvedIlya DryomovActions
Actions #1

Updated by Ilya Dryomov about 2 years ago

  • Status changed from In Progress to Fix Under Review
  • Backport set to pacific,quincy
  • Pull request ID set to 45744
Actions #2

Updated by Ilya Dryomov about 2 years ago

  • Related to Tasks #55159: stretch mode isn't covered in teuthology added
Actions #4

Updated by Neha Ojha about 2 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #5

Updated by Backport Bot about 2 years ago

  • Copied to Backport #55280: quincy: mon/OSDMonitor: properly set last_force_op_resend in stretch mode added
Actions #6

Updated by Backport Bot about 2 years ago

  • Copied to Backport #55281: pacific: mon/OSDMonitor: properly set last_force_op_resend in stretch mode added
Actions #7

Updated by Backport Bot almost 2 years ago

  • Tags set to backport_processed
Actions #8

Updated by Konstantin Shalygin over 1 year ago

  • Status changed from Pending Backport to Resolved
  • % Done changed from 0 to 100
  • Tags deleted (backport_processed)
Actions

Also available in: Atom PDF