Bug #55158
closedmon/OSDMonitor: properly set last_force_op_resend in stretch mode
100%
Description
Setting last_force_op_resend but not last_force_op_resend_prenautilus and last_force_op_resend_preluminous doesn't make sense. The reverse, such as
last_force_op_resend = 0
last_force_op_resend_prenautilus = 0
last_force_op_resend_preluminous = 20
or
last_force_op_resend = 0
last_force_op_resend_prenautilus = 40
last_force_op_resend_preluminous = 40
is valid in PG split/merge cases (and is the reason prenautilus and preluminous fields actually exist and aren't just encoding artifacts), but, if last_force_op_resend is set, both prenautilus and preluminous fields should really be set to the same value. Otherwise it basically amounts to "nautilus+ clients need to resend in-flight ops on stretch mode transitions but pre-nautilus clients don't" which is bogus as it leaves pre-nautilus clients exposed to the nastiness that necessitated employing the force resend hammer in the first place in https://github.com/ceph/ceph/commit/97fbd19ccd02046cb643239ac3c6fcb8404b4445.
Updated by Ilya Dryomov about 2 years ago
- Status changed from In Progress to Fix Under Review
- Backport set to pacific,quincy
- Pull request ID set to 45744
Updated by Ilya Dryomov about 2 years ago
- Related to Tasks #55159: stretch mode isn't covered in teuthology added
Updated by Yuri Weinstein about 2 years ago
Updated by Neha Ojha about 2 years ago
- Status changed from Fix Under Review to Pending Backport
Updated by Backport Bot about 2 years ago
- Copied to Backport #55280: quincy: mon/OSDMonitor: properly set last_force_op_resend in stretch mode added
Updated by Backport Bot about 2 years ago
- Copied to Backport #55281: pacific: mon/OSDMonitor: properly set last_force_op_resend in stretch mode added
Updated by Konstantin Shalygin over 1 year ago
- Status changed from Pending Backport to Resolved
- % Done changed from 0 to 100
- Tags deleted (
backport_processed)